RE: [alsa-devel] [PATCH 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver

2011-06-13 Thread Sangbeom Kim
On Thu, Jun 10, 2011 at 7:08 PM, Jassi Brar wrote: For my convenience, could you please tell how does it differ from my original implementation? Most things look same, except for a few variables. Original code only can support specific buffer size and period count. New idma driver can work

Re: [PATCH 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver

2011-06-10 Thread Jassi Brar
On Thu, Jun 9, 2011 at 1:39 PM, Sangbeom Kim sbki...@samsung.com wrote: I2S in Exynos4 and S5PC110(S5PV210) has a internal dma. It can be used low power audio mode and 2nd channel transfer. For my convenience, could you please tell how does it differ from my original implementation? Most

Re: [alsa-devel] [PATCH 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver

2011-06-09 Thread Liam Girdwood
On 09/06/11 09:09, Sangbeom Kim wrote: I2S in Exynos4 and S5PC110(S5PV210) has a internal dma. It can be used low power audio mode and 2nd channel transfer. Signed-off-by: Sangbeom Kim sbki...@samsung.com Looks fine to me, but needs one fix before it can be applied. Acked-by: Liam Girdwood

RE: [alsa-devel] [PATCH 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver

2011-06-09 Thread Sangbeom Kim
On Thu, Jun 9, 2011 at 9:33 PM, Kyungmin Park wrote: +#ifndef __S3C_IDMA_H_ +#define __S3C_IDMA_H_ + +#ifdef CONFIG_ARCH_EXYNOS4 +#define LP_TXBUFF_ADDR    (0x0202) +#else +#define LP_TXBUFF_ADDR    (0xC000) +#endif Are there more fancy way to define the internal DMA