Re: [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs

2010-12-07 Thread Ben Dooks
On 01/12/10 11:55, Mark Brown wrote: > On Wed, Dec 01, 2010 at 08:44:25PM +0900, Kukjin Kim wrote: >> Mark Brown wrote: > >>> This makes all the functions that use the shift slightly smaller, one >>> instruction in most cases but more for ack() and maskack(). > >> Uhm...I'm not sure to use chip_d

RE: [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs

2010-12-01 Thread Kukjin Kim
Mark Brown wrote: > > On Wed, Dec 01, 2010 at 08:44:25PM +0900, Kukjin Kim wrote: > > Mark Brown wrote: > > > > This makes all the functions that use the shift slightly smaller, one > > > instruction in most cases but more for ack() and maskack(). > > > Uhm...I'm not sure to use chip_data for th

Re: [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs

2010-12-01 Thread Mark Brown
On Wed, Dec 01, 2010 at 08:44:25PM +0900, Kukjin Kim wrote: > Mark Brown wrote: > > This makes all the functions that use the shift slightly smaller, one > > instruction in most cases but more for ack() and maskack(). > Uhm...I'm not sure to use chip_data for the eint_irq_to_bit() is best to us.

RE: [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs

2010-12-01 Thread Kukjin Kim
Mark Brown wrote: > > This makes all the functions that use the shift slightly smaller, one > instruction in most cases but more for ack() and maskack(). > Hi Mark, Uhm...I'm not sure to use chip_data for the eint_irq_to_bit() is best to us. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior

[PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs

2010-11-25 Thread Mark Brown
This makes all the functions that use the shift slightly smaller, one instruction in most cases but more for ack() and maskack(). Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/irq-eint.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-s3c64xx/