Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-03 Thread Sylwester Nawrocki
On 12/03/2010 05:53 AM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> There may be up to 2 MIPI-CSI2 interfaces depending on SoC version. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by: Kyungmin Park >> --- >> arch/arm/plat-s5p/Kconfig | 10 >> arch/ar

RE: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-03 Thread Marek Szyprowski
Hello, On Friday, December 03, 2010 2:37 AM Jassi Brar wrote: > On Fri, Dec 3, 2010 at 2:39 AM, Sylwester Nawrocki > > I agree explicit indices are not really needed. I just followed the style of > > all other resource definitions already there. > > I am not quite sure what is the preference o

Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-03 Thread Jamie Iles
On Fri, Dec 03, 2010 at 10:37:10AM +0900, Jassi Brar wrote: > On Fri, Dec 3, 2010 at 2:39 AM, Sylwester Nawrocki > wrote: > > > > Hi Jamie, > > > > On 12/02/2010 06:15 PM, Jamie Iles wrote: > >> Hi Sylwester, > >> > >> On Thu, Dec 02, 2010 at 05:37:41PM +0100, Sylwester Nawrocki wrote: > >>> diff

Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Kyungmin Park
On Fri, Dec 3, 2010 at 2:14 PM, Jassi Brar wrote: > On Fri, Dec 3, 2010 at 1:37 AM, Sylwester Nawrocki > wrote: >> There may be up to 2 MIPI-CSI2 interfaces depending on SoC version. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by: Kyungmin Park >> --- >>  arch/arm/plat-s5p/Kconfig    

Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Jassi Brar
On Fri, Dec 3, 2010 at 1:37 AM, Sylwester Nawrocki wrote: > There may be up to 2 MIPI-CSI2 interfaces depending on SoC version. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- >  arch/arm/plat-s5p/Kconfig                 |   10 >  arch/arm/plat-s5p/Makefile  

RE: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > There may be up to 2 MIPI-CSI2 interfaces depending on SoC version. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > arch/arm/plat-s5p/Kconfig | 10 > arch/arm/plat-s5p/Makefile|2 + > arch

Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Jassi Brar
On Fri, Dec 3, 2010 at 2:39 AM, Sylwester Nawrocki wrote: > > Hi Jamie, > > On 12/02/2010 06:15 PM, Jamie Iles wrote: >> Hi Sylwester, >> >> On Thu, Dec 02, 2010 at 05:37:41PM +0100, Sylwester Nawrocki wrote: >>> diff --git a/arch/arm/plat-s5p/dev-csis0.c b/arch/arm/plat-s5p/dev-csis0.c >>> new fi

Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Jamie Iles
On Thu, Dec 02, 2010 at 06:39:50PM +0100, Sylwester Nawrocki wrote: > On 12/02/2010 06:15 PM, Jamie Iles wrote: > > On Thu, Dec 02, 2010 at 05:37:41PM +0100, Sylwester Nawrocki wrote: [...] > >> +static struct resource s5p_csis_resource[] = { > >> + [0] = { > >> + .start = S5P_PA_CSIS0, >

Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Sylwester Nawrocki
Hi Jamie, On 12/02/2010 06:15 PM, Jamie Iles wrote: > Hi Sylwester, > > On Thu, Dec 02, 2010 at 05:37:41PM +0100, Sylwester Nawrocki wrote: >> diff --git a/arch/arm/plat-s5p/dev-csis0.c b/arch/arm/plat-s5p/dev-csis0.c >> new file mode 100644 >> index 000..2b1ba43 >> --- /dev/null >> +++ b/ar

Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Jamie Iles
Hi Sylwester, On Thu, Dec 02, 2010 at 05:37:41PM +0100, Sylwester Nawrocki wrote: > diff --git a/arch/arm/plat-s5p/dev-csis0.c b/arch/arm/plat-s5p/dev-csis0.c > new file mode 100644 > index 000..2b1ba43 > --- /dev/null > +++ b/arch/arm/plat-s5p/dev-csis0.c > @@ -0,0 +1,34 @@ > +/* > + * Copyri

[PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

2010-12-02 Thread Sylwester Nawrocki
There may be up to 2 MIPI-CSI2 interfaces depending on SoC version. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- arch/arm/plat-s5p/Kconfig | 10 arch/arm/plat-s5p/Makefile|2 + arch/arm/plat-s5p/dev-csis0.c | 34