RE: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-13 Thread boojin
Jassi Brar wrote: On Tue, Jul 5, 2011 at 12:03 PM, Chanho Park parkc...@gmail.com wrote: Kukjin Kim kgene.kim at samsung.com writes: (snip) + if (slave_config-direction == DMA_TO_DEVICE) { + if (slave_config-dst_addr) +

Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-13 Thread Jassi Brar
On Thu, Jul 14, 2011 at 6:27 AM, boojin boojin@samsung.com wrote: Jassi Brar wrote: On Tue, Jul 5, 2011 at 12:03 PM, Chanho Park parkc...@gmail.com wrote: Kukjin Kim kgene.kim at samsung.com writes: (snip) +             if (slave_config-direction == DMA_TO_DEVICE) { +            

Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-05 Thread Chanho Park
Kukjin Kim kgene.kim at samsung.com writes: (snip) + if (slave_config-direction == DMA_TO_DEVICE) { + if (slave_config-dst_addr) + peri-fifo_addr = slave_config-dst_addr; + if (slave_config-dst_addr_width) { +

Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-05 Thread Chanho Park
Basically, src_addr_width is defined as a 'enum dma_slave_buswidth' so I think we don't need to consider it. Client D/D normally uses 'enum dma_slave_buswidth' type. However, dmaengine driver cannot guarantee all client D/D uses it. See below your spi driver. Thus, the dmaengine driver check

[PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-04 Thread Kukjin Kim
From: Boojin Kim boojin@samsung.com This patch adds DMA_CYCLIC capability that is used for audio driver and SLAVE_CONFIG capability for transmit between device and memory. Signed-off-by: Boojin Kim boojin@samsung.com Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams