Re: [PATCH 4/4] [SCSI] ufshcd: SCSI error handling

2012-02-11 Thread Amit Sahrawat
Hi Santosh, Below is the original function in your patch: +static int ufshcd_abort(struct scsi_cmnd *cmd) +{ + struct Scsi_Host *host; + struct ufs_hba *hba; + unsigned long flags; + unsigned int tag; + unsigned int pos; + int err; + + host = cmd->device->h

Re: [PATCH 4/4] [SCSI] ufshcd: SCSI error handling

2012-02-06 Thread Santosh Y
On Mon, Feb 6, 2012 at 12:46 PM, Amit Sahrawat wrote: > Hi, > > In function: > +static int ufshcd_abort(struct scsi_cmnd *cmd) > +{... > -       int err; > +       int err = -1; > ... > +       spin_lock_irqsave(host->host_lock, flags); > +       pos = (1 << tag); > + > +       /* check if command

Re: [PATCH 4/4] [SCSI] ufshcd: SCSI error handling

2012-02-05 Thread Amit Sahrawat
Hi, In function: +static int ufshcd_abort(struct scsi_cmnd *cmd) +{... - int err; + int err = -1; ... + spin_lock_irqsave(host->host_lock, flags); + pos = (1 << tag); + + /* check if command is still pending */ + if (!(hba->outstanding_reqs & pos)) { -

Re: [PATCH 4/4] [SCSI] ufshcd: SCSI error handling

2012-02-05 Thread Santosh Y
On Sun, Feb 5, 2012 at 1:07 PM, Namjae Jeon wrote: >> + >> +/** >> + * ufshcd_abort - abort a specific command >> + * @cmd: SCSI command pointer >> + * >> + * Returns 0 on success, non-zero value on failure >> + */ >> +static int ufshcd_abort(struct scsi_cmnd *cmd) >> +{ >> +       struct Scsi_Hos

Re: [PATCH 4/4] [SCSI] ufshcd: SCSI error handling

2012-02-04 Thread Namjae Jeon
> + > +/** > + * ufshcd_abort - abort a specific command > + * @cmd: SCSI command pointer > + * > + * Returns 0 on success, non-zero value on failure > + */ > +static int ufshcd_abort(struct scsi_cmnd *cmd) > +{ > +       struct Scsi_Host *host; > +       struct ufs_hba *hba; > +       unsigned lon

[PATCH 4/4] [SCSI] ufshcd: SCSI error handling

2012-02-01 Thread Vinayak Holikatti
From: Santosh Yaraganavi UFSHCD SCSI error handling includes following implementations, - Abort task - Device reset - Host reset Signed-off-by: Santosh Yaraganavi Signed-off-by: Vinayak Holikatti Reviewed-by: Arnd Bergmann Reviewed-by: Saugata Das Reviewed-by: Vishak G Reviewed-by: Giris