RE: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-08 Thread Kukjin Kim
Ben Dooks wrote: > > On 07/09/10 06:29, Kukjin Kim wrote: > > From: Changhwan Youn > > > > This patch changes RTC initialization method on probe() as > > per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can > > check whether RTC BCD is valid or not. > > > > And should be changed the method o

RE: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-08 Thread Kukjin Kim
Wan ZongShun wrote: > > 2010/9/8 Ben Dooks : > > On 07/09/10 06:29, Kukjin Kim wrote: > >> From: Changhwan Youn > >> > >> This patch changes RTC initialization method on probe() as > >> per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can > >> check whether RTC BCD is valid or not. > >> > >

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Wan ZongShun
2010/9/8 Ben Dooks : > On 07/09/10 06:29, Kukjin Kim wrote: >> From: Changhwan Youn >> >> This patch changes RTC initialization method on probe() as >> per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can >> check whether RTC BCD is valid or not. >> Hi Kukjin, I think you misunderstood my m

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Ben Dooks
On 07/09/10 06:29, Kukjin Kim wrote: > From: Changhwan Youn > > This patch changes RTC initialization method on probe() as > per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can > check whether RTC BCD is valid or not. > > And should be changed the method of check because previous > method

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Kyungmin Park
On Tue, Sep 7, 2010 at 2:29 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This patch changes RTC initialization method on probe() as > per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can > check whether RTC BCD is valid or not. > > And should be changed the method of check because previo

[PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-06 Thread Kukjin Kim
From: Changhwan Youn This patch changes RTC initialization method on probe() as per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can check whether RTC BCD is valid or not. And should be changed the method of check because previous method cannot validate RTC BCD registers properly. Signed-o