Re: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Kyungmin Park
On Thu, Oct 21, 2010 at 11:36 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim wrote: >> > From: Seungwhan Youn >> > >> > This patch adds to enable/disable DMA operation clock on S3C-PL330 >> > DMA controller driver. >> >> The title and description s

RE: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Kukjin Kim
Jassi Brar wrote: > > On Thu, Oct 21, 2010 at 10:49 AM, Kyungmin Park wrote: > >>> Can you make it REAL clock gating, enable clock only when using? > >> > >> Of course we can. But that will need some intrusive changes. > >> Later, we'll implement that desirable feature. > >> For now, many SoCs do

RE: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Kukjin Kim
Kyungmin Park wrote: > > On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim wrote: > > From: Seungwhan Youn > > > > This patch adds to enable/disable DMA operation clock on S3C-PL330 > > DMA controller driver. > > The title and description seems to clock gating but actual code is > just enable at prob

Re: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Jassi Brar
On Thu, Oct 21, 2010 at 11:12 AM, Kyungmin Park wrote: > BTW, what's the id of mdma and which clock at c210? MDMA is not yet supported in Samsung mainline. Any ID can be assigned as long as it doesn't conflict with other DMAs and resources correctly attached to it. -- To unsubscribe from this li

Re: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Kyungmin Park
On Thu, Oct 21, 2010 at 10:54 AM, Jassi Brar wrote: > On Thu, Oct 21, 2010 at 10:49 AM, Kyungmin Park wrote: Can you make it REAL clock gating, enable clock only when using? >>> >>> Of course we can. But that will need some intrusive changes. >>> Later, we'll implement that desirable feature

Re: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Jassi Brar
On Thu, Oct 21, 2010 at 10:49 AM, Kyungmin Park wrote: >>> Can you make it REAL clock gating, enable clock only when using? >> >> Of course we can. But that will need some intrusive changes. >> Later, we'll implement that desirable feature. >> For now, many SoCs don't detect PL330 since the clocks

Re: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Kyungmin Park
On Thu, Oct 21, 2010 at 10:45 AM, Jassi Brar wrote: > On Thu, Oct 21, 2010 at 10:32 AM, Kyungmin Park wrote: >> On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim wrote: >>> From: Seungwhan Youn >>> >>> This patch adds to enable/disable DMA operation clock on S3C-PL330 >>> DMA controller driver. >> >>

Re: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Jassi Brar
On Thu, Oct 21, 2010 at 10:32 AM, Kyungmin Park wrote: > On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim wrote: >> From: Seungwhan Youn >> >> This patch adds to enable/disable DMA operation clock on S3C-PL330 >> DMA controller driver. > > The title and description seems to clock gating but actual co

Re: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Kyungmin Park
On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim wrote: > From: Seungwhan Youn > > This patch adds to enable/disable DMA operation clock on S3C-PL330 > DMA controller driver. The title and description seems to clock gating but actual code is just enable at probe and disable at remove. Can you make i

[PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

2010-10-20 Thread Kukjin Kim
From: Seungwhan Youn This patch adds to enable/disable DMA operation clock on S3C-PL330 DMA controller driver. Signed-off-by: Seungwhan Youn Acked-by: Jassi Brar Signed-off-by: Kukjin Kim --- arch/arm/plat-samsung/s3c-pl330.c | 34 +++--- 1 files changed, 27 ins