Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-13 Thread Javier Martinez Canillas
Hello Mark, On 08/12/2014 11:27 PM, Mark Brown wrote: On Tue, Aug 12, 2014 at 08:49:29PM +0200, Javier Martinez Canillas wrote: So, is adding these voltages ranges (the design limits) in the Peach Pit DTS file directly an acceptable solution? Basically what my previous patch [0] did.

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-13 Thread Mark Brown
On Wed, Aug 13, 2014 at 01:31:44PM +0200, Javier Martinez Canillas wrote: Please fix your mailer to word wrap at less than 80 columns, it makes your mails very hard to read when replying. On 08/12/2014 11:27 PM, Mark Brown wrote: Well, I think the question is if you understand where those

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-13 Thread Javier Martinez Canillas
On 08/13/2014 02:29 PM, Mark Brown wrote: Please fix your mailer to word wrap at less than 80 columns, it makes your mails very hard to read when replying. Sorry I had my wrap length configured to 80 but just changed to 74 now. On 08/12/2014 11:27 PM, Mark Brown wrote: No, that makes

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-13 Thread Mark Brown
On Wed, Aug 13, 2014 at 03:34:12PM +0200, Javier Martinez Canillas wrote: Indeed. I'll change mmc_regulator_get_ocrmask() in MMC core then to use regulator_can_change_voltage() to detect if the regulator is a fixed one and call regulator_get_voltage() instead of list_voltage() in that case.

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-13 Thread Stephen Warren
On 08/12/2014 10:44 AM, Javier Martinez Canillas wrote: The tps65090 PMU data manual [0] has a table that list the Recommended operating conditions for each regulator. Add the information about the FET constraints to its dtsi file. [0]: http://www.ti.com/lit/ds/symlink/tps65090.pdf I'm

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-13 Thread Javier Martinez Canillas
Hello Mark, On 08/13/2014 05:51 PM, Mark Brown wrote: On Wed, Aug 13, 2014 at 03:34:12PM +0200, Javier Martinez Canillas wrote: Indeed. I'll change mmc_regulator_get_ocrmask() in MMC core then to use regulator_can_change_voltage() to detect if the regulator is a fixed one and call

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-13 Thread Javier Martinez Canillas
Hello Stephen, On 08/13/2014 06:16 PM, Stephen Warren wrote: I'm worried that this file represents the limits of the PMIC itself, whereas the DT should be representing the limits of the circuits that the various PMIC regulators are attached to on the board. For example: diff --git

[PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-12 Thread Javier Martinez Canillas
The tps65090 PMU data manual [0] has a table that list the Recommended operating conditions for each regulator. Add the information about the FET constraints to its dtsi file. [0]: http://www.ti.com/lit/ds/symlink/tps65090.pdf Signed-off-by: Javier Martinez Canillas

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-12 Thread Javier Martinez Canillas
On 08/12/2014 07:25 PM, Mark Brown wrote: tps65090_fet1: fet1 { +regulator-min-microvolt = 500; +regulator-max-microvolt = 1700; }; No, this is completely broken and exactly the sort of thing that makes doing

Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

2014-08-12 Thread Mark Brown
On Tue, Aug 12, 2014 at 08:49:29PM +0200, Javier Martinez Canillas wrote: So, is adding these voltages ranges (the design limits) in the Peach Pit DTS file directly an acceptable solution? Basically what my previous patch [0] did. That matches what is in the board schematic so I assume that