Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-10-12 Thread Sylwester Nawrocki
On 09/30/2013 11:50 AM, Hans Verkuil wrote: On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > TODO: Add setting of default initial format. So this patch can't be applied yet. Indeed, it's just an RFC series, I wanted it to g

Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > TODO: Add setting of default initial format. So this patch can't be applied yet. Other than that it looks good, but I won't ack it since it introduces a regression as long as the

Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-15 Thread Sylwester Nawrocki
Hi Shaik, On 09/13/2013 04:12 PM, Shaik Ameer Basha wrote: [...] -static int gsc_m2m_streamon(struct file *file, void *fh, - enum v4l2_buf_type type) -{ - struct gsc_ctx *ctx = fh_to_ctx(fh); - - /* The source and target color format need to be set */ -

Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-13 Thread Shaik Ameer Basha
Hi Sylwester, On Fri, Sep 13, 2013 at 6:26 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > TODO: Add setting of default initial format. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyugmin Park > --- > drivers/media/platform/exynos-gsc/

[PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-13 Thread Sylwester Nawrocki
Simplify the driver by using the m2m ioctl and vb2 helpers. TODO: Add setting of default initial format. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyugmin Park --- drivers/media/platform/exynos-gsc/gsc-core.h | 12 --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 109 --