Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2011-09-28 Thread Viresh Kumar
On 9/28/2011 11:20 AM, Alim Akhtar wrote: Signed-off-by: Alim Akhtar alim.akh...@samsung.com --- drivers/dma/amba-pl08x.c | 135 ++ 1 files changed, 112 insertions(+), 23 deletions(-) It would be good if you can add pick some part from

Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2011-09-28 Thread Linus Walleij
Sorry if I missed a few nitpicks last time, anyway it's looking much better now: On Wed, Sep 28, 2011 at 7:50 AM, Alim Akhtar alim.akh...@samsung.com wrote: +       /* +        * Samsung pl080 DMAC has one exrta control register s/exrta/exstra +       if (pl08x-vd-is_pl080_s3c) { +          

Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2011-09-28 Thread Alim Akhtar
Hi Viresh, Thanks for reviewing the patch. On Wed, Sep 28, 2011 at 1:15 PM, Viresh Kumar viresh.ku...@st.com wrote: On 9/28/2011 11:20 AM, Alim Akhtar wrote: Signed-off-by: Alim Akhtar alim.akh...@samsung.com ---  drivers/dma/amba-pl08x.c |  135

Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2011-09-28 Thread Alim Akhtar
HI Linus, Thanks for reviewing again. On Wed, Sep 28, 2011 at 1:31 PM, Linus Walleij linus.wall...@linaro.org wrote: Sorry if I missed a few nitpicks last time, anyway it's looking much better now: On Wed, Sep 28, 2011 at 7:50 AM, Alim Akhtar alim.akh...@samsung.com wrote: +       /* +    

Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2011-09-28 Thread Viresh Kumar
On 9/28/2011 2:20 PM, Alim Akhtar wrote: The main difference between Primecell PL080 and samsung variant is in LLI control register bit [0:11] is reserved in case of samsung pl080 and one extra register is add to hold the transfer size at offset 0x10. The purpose of cctl1 is store the

Re: [PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2011-09-28 Thread Alim Akhtar
On Wed, Sep 28, 2011 at 3:24 PM, Viresh Kumar viresh.ku...@st.com wrote: On 9/28/2011 2:20 PM, Alim Akhtar wrote: The main difference between Primecell PL080 and samsung variant is in LLI control register bit [0:11] is reserved in case of samsung pl080 and one extra register is add to hold the

[PATCH V2 1/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2011-09-27 Thread Alim Akhtar
Signed-off-by: Alim Akhtar alim.akh...@samsung.com --- drivers/dma/amba-pl08x.c | 135 ++ 1 files changed, 112 insertions(+), 23 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index cd8df7f..501540f 100644 ---