On 9/28/2011 5:24 PM, Alim Akhtar wrote:
> I did Modified pl08x_cctl_bits(), but for some reason i reverted it back.
> what i was doing something like returning just __retbits__ instead of
> retbits |= tsize << PL080_CONTROL_TRANSFER_SIZE_SHIFT;
> and doing the below for the __non-s3c__ controllers
On Wed, Sep 28, 2011 at 3:24 PM, Viresh Kumar wrote:
> On 9/28/2011 2:20 PM, Alim Akhtar wrote:
>> The main difference between Primecell PL080 and samsung variant is in
>> LLI control register bit [0:11] is reserved in case of samsung pl080
>> and one extra register is add to hold the transfer siz
On 9/28/2011 2:20 PM, Alim Akhtar wrote:
> The main difference between Primecell PL080 and samsung variant is in
> LLI control register bit [0:11] is reserved in case of samsung pl080
> and one extra register is add to hold the transfer size at offset
> 0x10. The purpose of cctl1 is store the trans
HI Linus,
Thanks for reviewing again.
On Wed, Sep 28, 2011 at 1:31 PM, Linus Walleij wrote:
> Sorry if I missed a few nitpicks last time, anyway it's looking much better
> now:
>
> On Wed, Sep 28, 2011 at 7:50 AM, Alim Akhtar wrote:
>> + /*
>> + * Samsung pl080 DMAC has one exrta c
Hi Viresh,
Thanks for reviewing the patch.
On Wed, Sep 28, 2011 at 1:15 PM, Viresh Kumar wrote:
> On 9/28/2011 11:20 AM, Alim Akhtar wrote:
>> Signed-off-by: Alim Akhtar
>> ---
>> drivers/dma/amba-pl08x.c | 135
>> ++
>> 1 files changed, 112 insert
Sorry if I missed a few nitpicks last time, anyway it's looking much better now:
On Wed, Sep 28, 2011 at 7:50 AM, Alim Akhtar wrote:
> + /*
> + * Samsung pl080 DMAC has one exrta control register
s/exrta/exstra
> + if (pl08x->vd->is_pl080_s3c) {
> + writel(txd->
On 9/28/2011 11:20 AM, Alim Akhtar wrote:
> Signed-off-by: Alim Akhtar
> ---
> drivers/dma/amba-pl08x.c | 135
> ++
> 1 files changed, 112 insertions(+), 23 deletions(-)
>
It would be good if you can add pick some part from cover-letter and put it i
Signed-off-by: Alim Akhtar
---
drivers/dma/amba-pl08x.c | 135 ++
1 files changed, 112 insertions(+), 23 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index cd8df7f..501540f 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/d
