RE: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-04 Thread Kukjin Kim
Arnd Bergmann wrote: > > On Tuesday 04 October 2011, Kukjin Kim wrote: > > > I think the string concatenation really just obfuscates the code, and > > > it does not actually save much at all. When you replace > > > > > > + [0] = SAMSUNG_RES_MEM(S3C, WDT, SZ_1K), > > > + [1] = SAMSUNG_R

RE: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-04 Thread Kukjin Kim
Kyungmin Park wrote: > > On Wed, Oct 5, 2011 at 12:26 AM, Arnd Bergmann wrote: > > On Tuesday 04 October 2011, Kukjin Kim wrote: > >> > I think the string concatenation really just obfuscates the code, and > >> > it does not actually save much at all. When you replace > >> > > >> > +       [0] =

Re: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-04 Thread Kyungmin Park
On Wed, Oct 5, 2011 at 12:26 AM, Arnd Bergmann wrote: > On Tuesday 04 October 2011, Kukjin Kim wrote: >> > I think the string concatenation really just obfuscates the code, and >> > it does not actually save much at all. When you replace >> > >> > +       [0] = SAMSUNG_RES_MEM(S3C, WDT, SZ_1K), >>

Re: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-04 Thread Arnd Bergmann
On Tuesday 04 October 2011, Kukjin Kim wrote: > > I think the string concatenation really just obfuscates the code, and > > it does not actually save much at all. When you replace > > > > + [0] = SAMSUNG_RES_MEM(S3C, WDT, SZ_1K), > > + [1] = SAMSUNG_RES_IRQ(WDT), > > > > with > > > >

RE: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-04 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > On 10/03/2011 03:13 PM, Kukjin Kim wrote: > > On 10/03/11 12:53, Kyungmin Park wrote: > >> On Mon, Oct 3, 2011 at 12:41 PM, Kukjin Kim > wrote: > >>> > >>> +#define SAMSUNG_RES_MEM(soc, ip, sz) > DEFINE_RES_MEM(soc##_PA_##ip, sz) > >>> +#define SAMSUNG_RES_IRQ(ip)

RE: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-04 Thread Kukjin Kim
Arnd Bergmann wrote: > > On Monday 03 October 2011 12:41:22 Kukjin Kim wrote: > > This patch adds macro SAMSUNG_RES_MEM, SAMSUNG_RES_IRQ > > and so on to cleanup regarding 'struct resource' by using > > defined helpers at . > > > > Cc: Ben Dooks > > Signed-off-by: Kukjin Kim > > When we introdu

Re: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-03 Thread Arnd Bergmann
On Monday 03 October 2011 12:41:22 Kukjin Kim wrote: > This patch adds macro SAMSUNG_RES_MEM, SAMSUNG_RES_IRQ > and so on to cleanup regarding 'struct resource' by using > defined helpers at . > > Cc: Ben Dooks > Signed-off-by: Kukjin Kim When we introduced those macros, it was specifically so

Re: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-03 Thread Sylwester Nawrocki
On 10/03/2011 03:13 PM, Kukjin Kim wrote: > On 10/03/11 12:53, Kyungmin Park wrote: >> On Mon, Oct 3, 2011 at 12:41 PM, Kukjin Kim wrote: >>> >>> +#define SAMSUNG_RES_MEM(soc, ip, sz) DEFINE_RES_MEM(soc##_PA_##ip, sz) >>> +#define SAMSUNG_RES_IRQ(ip)DEFINE_RES_IRQ(IRQ_##ip) >>> + >>>

Re: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-03 Thread Kukjin Kim
On 10/03/11 12:53, Kyungmin Park wrote: On Mon, Oct 3, 2011 at 12:41 PM, Kukjin Kim wrote: This patch adds macro SAMSUNG_RES_MEM, SAMSUNG_RES_IRQ and so on to cleanup regarding 'struct resource' by using defined helpers at. Cc: Ben Dooks Signed-off-by: Kukjin Kim --- Changes since v1: - Addres

Re: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-02 Thread Kyungmin Park
On Mon, Oct 3, 2011 at 12:41 PM, Kukjin Kim wrote: > This patch adds macro SAMSUNG_RES_MEM, SAMSUNG_RES_IRQ > and so on to cleanup regarding 'struct resource' by using > defined helpers at . > > Cc: Ben Dooks > Signed-off-by: Kukjin Kim > --- > Changes since v1: > - Address comments from Russell

[PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-02 Thread Kukjin Kim
This patch adds macro SAMSUNG_RES_MEM, SAMSUNG_RES_IRQ and so on to cleanup regarding 'struct resource' by using defined helpers at . Cc: Ben Dooks Signed-off-by: Kukjin Kim --- Changes since v1: - Address comments from Russell King Using defined helpers to define resource arch/arm/mach-s3c24