[PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-12 Thread Padmavathi Venna
From: Andrew Bresticker This adds device-tree bindings for the i2s controllers on Exynos 5420. Signed-off-by: Andrew Bresticker Signed-off-by: Padmavathi Venna Reviewed-on: https://gerrit.chromium.org/gerrit/57713 --- arch/arm/boot/dts/exynos5420.dtsi | 32

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-12 Thread Tomasz Figa
Hi Padmavathi, Andrew, On Monday 12 of August 2013 15:37:47 Padmavathi Venna wrote: > From: Andrew Bresticker > > This adds device-tree bindings for the i2s controllers on Exynos 5420. > > Signed-off-by: Andrew Bresticker > Signed-off-by: Padmavathi Venna > Reviewed-on: https://gerrit.chromiu

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 01:14:20PM +0200, Tomasz Figa wrote: > On Monday 12 of August 2013 15:37:47 Padmavathi Venna wrote: > > + i2s_0: i2s@0383 { > > + status = "disabled"; > If a node does not require any board-specific properties for the device to > operate properly, there is

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-12 Thread Tomasz Figa
On Monday 12 of August 2013 12:34:48 Mark Brown wrote: > On Mon, Aug 12, 2013 at 01:14:20PM +0200, Tomasz Figa wrote: > > On Monday 12 of August 2013 15:37:47 Padmavathi Venna wrote: > > > + i2s_0: i2s@0383 { > > > + status = "disabled"; > > > > If a node does not require any board-spe

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 01:41:23PM +0200, Tomasz Figa wrote: > On Monday 12 of August 2013 12:34:48 Mark Brown wrote: > > I'd expect that to interact badly with the pinmuxing - unless the device > > is disabled it'll try to grab its pins on probe which is not going to be > > a good idea unless it

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-12 Thread Tomasz Figa
On Monday 12 of August 2013 14:12:36 Mark Brown wrote: > On Mon, Aug 12, 2013 at 01:41:23PM +0200, Tomasz Figa wrote: > > On Monday 12 of August 2013 12:34:48 Mark Brown wrote: > > > I'd expect that to interact badly with the pinmuxing - unless the > > > device is disabled it'll try to grab its pin

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-13 Thread Padma Venkat
Hi Tomasz, On Mon, Aug 12, 2013 at 10:32 PM, Tomasz Figa wrote: > On Monday 12 of August 2013 14:12:36 Mark Brown wrote: >> On Mon, Aug 12, 2013 at 01:41:23PM +0200, Tomasz Figa wrote: >> > On Monday 12 of August 2013 12:34:48 Mark Brown wrote: >> > > I'd expect that to interact badly with the pi

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-14 Thread Tomasz Figa
On Wednesday 14 of August 2013 11:21:40 Padma Venkat wrote: > Hi Tomasz, > > On Mon, Aug 12, 2013 at 10:32 PM, Tomasz Figa wrote: > > On Monday 12 of August 2013 14:12:36 Mark Brown wrote: > >> On Mon, Aug 12, 2013 at 01:41:23PM +0200, Tomasz Figa wrote: > >> > On Monday 12 of August 2013 12:34: