RE: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

2011-07-26 Thread Boojin Kim
el.com; linux-arm-ker...@lists.infradead.org; > linux- > > > samsung-...@vger.kernel.org; Kukjin Kim; Jassi Brar; Grant Likely; > > > Mark Brown; Dan Williams > > > Subject: Re: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine > API > > > > > &

RE: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

2011-07-26 Thread Vinod Koul
Likely; > > Mark Brown; Dan Williams > > Subject: Re: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API > > > > On Mon, 2011-07-25 at 10:28 +0900, Boojin Kim wrote: > > > This patch adds to support DMA generic API to transfer raw > > > SPI data. Basicl

RE: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

2011-07-26 Thread Boojin Kim
Vinod Koul Wrote: > Sent: Monday, July 25, 2011 8:17 PM > To: Boojin Kim > Cc: vinod.k...@intel.com; linux-arm-ker...@lists.infradead.org; linux- > samsung-...@vger.kernel.org; Kukjin Kim; Jassi Brar; Grant Likely; > Mark Brown; Dan Williams > Subject: Re: [PATCH V4 12/14] spi/s3

Re: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

2011-07-25 Thread Vinod Koul
On Mon, 2011-07-25 at 10:28 +0900, Boojin Kim wrote: > This patch adds to support DMA generic API to transfer raw > SPI data. Basiclly the spi driver uses DMA generic API if > architecture supports it. Otherwise, uses Samsung specific > S3C-PL330 APIs. > > Signed-off-by: Boojin Kim > Cc: Grant Li

RE: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

2011-07-25 Thread Boojin Kim
Russell King - ARM Linux Wrote: > Sent: Monday, July 25, 2011 6:40 PM > To: Boojin Kim > Cc: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org; > Kukjin Kim; Vinod Koul; Jassi Brar; Grant Likely; Mark Brown; Dan Williams > Subject: Re: [PATCH V4 12/14] s

Re: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

2011-07-25 Thread Russell King - ARM Linux
On Mon, Jul 25, 2011 at 10:28:30AM +0900, Boojin Kim wrote: > +static void s3c64xx_spi_dma_rxcb(void *data) > +{ > + struct s3c64xx_spi_driver_data *sdd > + = (struct s3c64xx_spi_driver_data *)data; You never need explicit casts from void * or to void *. Please remove these. -- To

[PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

2011-07-24 Thread Boojin Kim
This patch adds to support DMA generic API to transfer raw SPI data. Basiclly the spi driver uses DMA generic API if architecture supports it. Otherwise, uses Samsung specific S3C-PL330 APIs. Signed-off-by: Boojin Kim Cc: Grant Likely Signed-off-by: Kukjin Kim --- drivers/spi/spi_s3c64xx.c |