Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-07-16 Thread Thierry Reding
On Fri, Jun 14, 2013 at 02:38:49PM +0200, Arnd Bergmann wrote: > On Friday 14 June 2013 12:53:11 Thierry Reding wrote: > > > > I think the biggest missing piece is pci_common_exit(), the counterpart > > of pci_common_init(), to cleanup a host bridge on ARM. I haven't looked > > in detail at the ot

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-19 Thread Jingoo Han
On Wednesday, June 19, 2013 9:43 PM, Arnd Bergmann wrote: > On Wednesday 19 June 2013, Jingoo Han wrote: > > Then, do you mean the following? > > > > static int __exit exynos_pcie_remove(struct platform_device *pdev) > > { > > struct pcie_port *pp = platform_get_drvdata(pdev); > > > >

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-19 Thread Arnd Bergmann
On Wednesday 19 June 2013, Jingoo Han wrote: > Then, do you mean the following? > > static int __exit exynos_pcie_remove(struct platform_device *pdev) > { > struct pcie_port *pp = platform_get_drvdata(pdev); > > clk_disable_unprepare(pp->bus_clk); > clk_disable_unprepare(p

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-18 Thread Jingoo Han
On Tuesday, June 18, 2013 10:57 PM, Arnd Bergmann wrote: > On Tuesday 18 June 2013, Jingoo Han wrote: > > On Monday, June 17, 2013 9:45 PM, Arnd Bergmann wrote: > > > On Monday 17 June 2013 18:45:52 Jingoo Han wrote: > > > > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > > > > > [.]

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Jingoo Han wrote: > On Monday, June 17, 2013 9:45 PM, Arnd Bergmann wrote: > > On Monday 17 June 2013 18:45:52 Jingoo Han wrote: > > > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > > > > > > > > Please look up the documentation about inbound viewport and describe

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-17 Thread Jingoo Han
On Monday, June 17, 2013 9:45 PM, Arnd Bergmann wrote: > On Monday 17 June 2013 18:45:52 Jingoo Han wrote: > > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > > > [.] > > > > > > +static int __exit exynos_pcie_remove(struct platform_device *pdev) > > > > > > +{ > > > > > > + struct p

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-17 Thread Jingoo Han
On Monday, June 17, 2013 9:45 PM, Arnd Bergmann wrote: > On Monday 17 June 2013 18:45:52 Jingoo Han wrote: > > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > > > > > > Please look up the documentation about inbound viewport and describe > > > in a code comment what it does. I /assume/ tha

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-17 Thread Arnd Bergmann
On Monday 17 June 2013 18:45:52 Jingoo Han wrote: > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > > > > Please look up the documentation about inbound viewport and describe > > in a code comment what it does. I /assume/ that this is how DMA accesses > > from the bus get translated into

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-17 Thread Jingoo Han
On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > On Friday 14 June 2013 17:18:46 Jingoo Han wrote: > > On Thursday, June 13, 2013 11:14 PM, Arnd Bergmann wrote: > > > On Thursday 13 June 2013 22:22:31 Jingoo Han wrote: > > > > > +struct pcie_port { > > > > + struct device *

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-14 Thread Arnd Bergmann
On Friday 14 June 2013 17:18:46 Jingoo Han wrote: > On Thursday, June 13, 2013 11:14 PM, Arnd Bergmann wrote: > > On Thursday 13 June 2013 22:22:31 Jingoo Han wrote: > > > +struct pcie_port { > > > + struct device *dev; > > > + u8 controller; > > > + u8

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-14 Thread Arnd Bergmann
On Friday 14 June 2013 12:53:11 Thierry Reding wrote: > > I think the biggest missing piece is pci_common_exit(), the counterpart > of pci_common_init(), to cleanup a host bridge on ARM. I haven't looked > in detail at the other architectures, but I suspect there must be some > code to call when a

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-14 Thread Thierry Reding
On Fri, Jun 14, 2013 at 05:18:46PM +0900, Jingoo Han wrote: > On Thursday, June 13, 2013 11:14 PM, Arnd Bergmann wrote: > > On Thursday 13 June 2013 22:22:31 Jingoo Han wrote: [...] > > > +static int __exit exynos_pcie_remove(struct platform_device *pdev) > > > +{ > > > + struct pcie_port *pp = pla

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-14 Thread Jingoo Han
On Thursday, June 13, 2013 11:14 PM, Arnd Bergmann wrote: > On Thursday 13 June 2013 22:22:31 Jingoo Han wrote: > > > +struct pcie_port_info { > > + u32 cfg0_size; > > + u32 cfg1_size; > > + u32 io_size; > > + u32 mem_size; > > + phys_addr_

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-13 Thread Arnd Bergmann
On Thursday 13 June 2013 22:22:31 Jingoo Han wrote: > +struct pcie_port_info { > + u32 cfg0_size; > + u32 cfg1_size; > + u32 io_size; > + u32 mem_size; > + phys_addr_t io_bus_addr; > + phys_addr_t mem_bus_addr; > +}; >

[PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-13 Thread Jingoo Han
Exynos5440 has a PCIe controller which can be used as Root Complex. This driver supports a PCIe controller as Root Complex mode. Signed-off-by: Surendranath Gurivireddy Balla Signed-off-by: Siva Reddy Kallam Signed-off-by: Jingoo Han --- Tested on Exynos5440. .../devicetree/bindings/pci/exyno