Re: [PATCH v10 5/6] rtc: max77686: Use ffs() to calculate tm_wday

2014-09-19 Thread Javier Martinez Canillas
Hello Joe, On 09/19/2014 09:52 PM, Joe Perches wrote: > On Fri, 2014-09-19 at 21:27 +0200, Javier Martinez Canillas wrote: >> On 09/19/2014 04:39 PM, Joe Perches wrote: >> > On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote: >> >> The function max77686_rtc_calculate_wday() is used

Re: [PATCH v10 5/6] rtc: max77686: Use ffs() to calculate tm_wday

2014-09-19 Thread Joe Perches
On Fri, 2014-09-19 at 21:27 +0200, Javier Martinez Canillas wrote: > Hello Joe, Hello Javier. > On 09/19/2014 04:39 PM, Joe Perches wrote: > > On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote: > >> The function max77686_rtc_calculate_wday() is used to > >> calculate the day of th

Re: [PATCH v10 5/6] rtc: max77686: Use ffs() to calculate tm_wday

2014-09-19 Thread Javier Martinez Canillas
Hello Joe, On 09/19/2014 04:39 PM, Joe Perches wrote: > On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote: >> The function max77686_rtc_calculate_wday() is used to >> calculate the day of the week to be filled in struct >> rtc_time but that function only calculates the number >> of

Re: [PATCH v10 5/6] rtc: max77686: Use ffs() to calculate tm_wday

2014-09-19 Thread Joe Perches
On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote: > The function max77686_rtc_calculate_wday() is used to > calculate the day of the week to be filled in struct > rtc_time but that function only calculates the number > of bits shifted. So the ffs() function can be used to > find th

[PATCH v10 5/6] rtc: max77686: Use ffs() to calculate tm_wday

2014-09-19 Thread Javier Martinez Canillas
The function max77686_rtc_calculate_wday() is used to calculate the day of the week to be filled in struct rtc_time but that function only calculates the number of bits shifted. So the ffs() function can be used to find the first bit set instead of a special function. Signed-off-by: Javier Martine