RE: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-06-03 Thread Kukjin Kim
Ben Dooks wrote: > > On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: > > From: Jongpill Lee > > > > This patch adds suspend-to-ram support for S5PV210. > > > > Signed-off-by: Jongpill Lee > > Signed-off-by: Kukjin Kim > > --- > > Changes since v1: > > > > 1. Fixed comments as per co

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-06-01 Thread Mark Brown
On Tue, Jun 01, 2010 at 05:16:33AM +0100, Ben Dooks wrote: > On Tue, Jun 01, 2010 at 12:23:39PM +0900, Kyungmin Park wrote: > > It's common function. Please add it to platform init instead of each board > > init. > I know Mark Brown would rather this be the case too, but the original intent > wa

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Ben Dooks
On Tue, Jun 01, 2010 at 02:13:18PM +0900, MyungJoo Ham wrote: > On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks wrote: > > > > On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: > >> From: Jongpill Lee > >> > >> This patch adds suspend-to-ram support for S5PV210. > >> > >> Signed-off-by: Jong

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread MyungJoo Ham
On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks wrote: > > On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: >> From: Jongpill Lee >> >> This patch adds suspend-to-ram support for S5PV210. >> >> Signed-off-by: Jongpill Lee >> Signed-off-by: Kukjin Kim >> --- >> Changes since v1: >> >> 1. F

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Kyungmin Park
On Tue, Jun 1, 2010 at 1:16 PM, Ben Dooks wrote: > On Tue, Jun 01, 2010 at 12:23:39PM +0900, Kyungmin Park wrote: >> On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks wrote: >> > >> > On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: >> >> From: Jongpill Lee >> >> >> >> This patch adds suspen

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Ben Dooks
On Tue, Jun 01, 2010 at 12:23:39PM +0900, Kyungmin Park wrote: > On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks wrote: > > > > On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: > >> From: Jongpill Lee > >> > >> This patch adds suspend-to-ram support for S5PV210. > >> > >> Signed-off-by: Jon

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Kyungmin Park
On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks wrote: > > On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: >> From: Jongpill Lee >> >> This patch adds suspend-to-ram support for S5PV210. >> >> Signed-off-by: Jongpill Lee >> Signed-off-by: Kukjin Kim >> --- >> Changes since v1: >> >> 1. F

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Ben Dooks
On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: > From: Jongpill Lee > > This patch adds suspend-to-ram support for S5PV210. > > Signed-off-by: Jongpill Lee > Signed-off-by: Kukjin Kim > --- > Changes since v1: > > 1. Fixed comments as per comments from Ben Dooks > 2. Removed red

[PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Kukjin Kim
From: Jongpill Lee This patch adds suspend-to-ram support for S5PV210. Signed-off-by: Jongpill Lee Signed-off-by: Kukjin Kim --- Changes since v1: 1. Fixed comments as per comments from Ben Dooks 2. Removed redunt #if defined(CONFIG_PM) 3. Removed redunt including header files 4. Removed and