Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Mark Brown
On Wed, Sep 01, 2010 at 07:36:40PM +0900, Kyungmin Park wrote: > As your word, first check the ID1 to detect the 8649 and 8952 and read > ID2 again to distinguish it. But actually we pass the max8952 as > platform device, so don't need to read ID2. If you can read the ID from the chip it's always

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Kyungmin Park
On Wed, Sep 1, 2010 at 7:27 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Wed, Sep 1, 2010 at 6:44 PM, Kukjin Kim wrote: >> > Mark Brown wrote: >> >> >> >> On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: >> >> >> >> > Seems almost same between the operation of max8649 and max8

RE: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Kukjin Kim
Kyungmin Park wrote: > > On Wed, Sep 1, 2010 at 6:44 PM, Kukjin Kim wrote: > > Mark Brown wrote: > >> > >> On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: > >> > >> > Seems almost same between the operation of max8649 and max8952 except > >> output > >> > voltage range. > >> > >> > Ho

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Kyungmin Park
On Wed, Sep 1, 2010 at 6:44 PM, Kukjin Kim wrote: > Mark Brown wrote: >> >> On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: >> >> > Seems almost same between the operation of max8649 and max8952 except >> output >> > voltage range. >> >> > How do you think that can support max8952 with

RE: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Kukjin Kim
Mark Brown wrote: > > On Wed, Sep 01, 2010 at 06:44:11PM +0900, Kukjin Kim wrote: > > > MM...but I'm not sure if I can submit other patch for max8952... > > Actually, Mr. Ham's max8952 code has been applied by Liam. > > We can always remove that if it makes more sense to combine the code. > > >

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Mark Brown
On Wed, Sep 01, 2010 at 06:44:11PM +0900, Kukjin Kim wrote: > MM...but I'm not sure if I can submit other patch for max8952... > Actually, Mr. Ham's max8952 code has been applied by Liam. We can always remove that if it makes more sense to combine the code. > - return (MAX8649_DCDC_VMIN + in

RE: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Kukjin Kim
Mark Brown wrote: > > On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: > > > Seems almost same between the operation of max8649 and max8952 except > output > > voltage range. > > > How do you think that can support max8952 with small modifying max8649? > > Take a look at something li

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Mark Brown
On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: > Seems almost same between the operation of max8649 and max8952 except output > voltage range. > How do you think that can support max8952 with small modifying max8649? Take a look at something like the WM831x drivers for how you can h

RE: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-08-31 Thread Kukjin Kim
Mark Brown wrote: > > On Fri, 2010-08-20 at 10:53 +0100, Mark Brown wrote: > > On Fri, Aug 20, 2010 at 02:43:56PM +0900, MyungJoo Ham wrote: > > > MAX8952 PMIC is used to provide voltage output between 770mV - 1400mV > > > with DVS support. In this initial release, users can set voltages for > > >

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-08-20 Thread Liam Girdwood
On Fri, 2010-08-20 at 10:53 +0100, Mark Brown wrote: > On Fri, Aug 20, 2010 at 02:43:56PM +0900, MyungJoo Ham wrote: > > MAX8952 PMIC is used to provide voltage output between 770mV - 1400mV > > with DVS support. In this initial release, users can set voltages for > > four DVS modes, RAMP delay val

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-08-20 Thread Mark Brown
On Fri, Aug 20, 2010 at 02:43:56PM +0900, MyungJoo Ham wrote: > MAX8952 PMIC is used to provide voltage output between 770mV - 1400mV > with DVS support. In this initial release, users can set voltages for > four DVS modes, RAMP delay values, and SYNC frequency. > Controlling FPWM/SYNC_MODE/Pull-Do

[PATCH v2] MAX8952 PMIC Driver Initial Release

2010-08-19 Thread MyungJoo Ham
MAX8952 PMIC is used to provide voltage output between 770mV - 1400mV with DVS support. In this initial release, users can set voltages for four DVS modes, RAMP delay values, and SYNC frequency. Controlling FPWM/SYNC_MODE/Pull-Down/Ramp Modes and reading CHIP_ID is not supported in this release. I