[PATCH v2 1/4] regulator: max77686: Replace hard-coded opmode values with defines

2014-10-21 Thread Krzysztof Kozlowski
Add defines for regulator operating modes which should be more readable, especially if one does not have Maxim 77686 datasheet. The patch does not introduce any functional change. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Javier Martinez Canillas

Re: [PATCH v2 1/4] regulator: max77686: Replace hard-coded opmode values with defines

2014-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks a lot for the re-spin. On 10/21/2014 01:23 PM, Krzysztof Kozlowski wrote: Add defines for regulator operating modes which should be more readable, especially if one does not have Maxim 77686 datasheet. The patch does not introduce any functional change.

Re: [PATCH v2 1/4] regulator: max77686: Replace hard-coded opmode values with defines

2014-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/21/2014 02:22 PM, Krzysztof Kozlowski wrote: On wto, 2014-10-21 at 13:57 +0200, Javier Martinez Canillas wrote: +/* On/off controlled by PWRREQ */ +#define MAX77686_OPMODE_OFF_PWRREQ0x1 Minor nit: maybe this should be called MAX77802_OFF_PWRREQ (without