On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote:
Hi,
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
+static struct platform_driver exynos_video_phy_driver = {
+.probe = exynos_video_phy_probe,
you *must* provide a remove method. drivers with NULL remove are
Hi Felipe,
On 06/27/2013 08:17 AM, Felipe Balbi wrote:
On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote:
Hi,
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
+static struct platform_driver exynos_video_phy_driver = {
+ .probe = exynos_video_phy_probe,
you *must* provide a
On Thu, Jun 27, 2013 at 09:47:47AM +0200, Andrzej Hajda wrote:
Hi Felipe,
On 06/27/2013 08:17 AM, Felipe Balbi wrote:
On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote:
Hi,
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
+static struct platform_driver
On Thu, Jun 27, 2013 at 09:17:13AM +0300, Felipe Balbi wrote:
On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote:
Hi,
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
+static struct platform_driver exynos_video_phy_driver = {
+ .probe = exynos_video_phy_probe,
Hi,
On Wednesday 26 June 2013 02:24 AM, Felipe Balbi wrote:
Hi,
On Tue, Jun 25, 2013 at 07:44:52PM +0200, Sylwester Nawrocki wrote:
+struct exynos_video_phy {
+ spinlock_t slock;
+ struct phy *phys[NUM_PHYS];
more than one phy ? This means you should instantiate driver multiple
On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote:
+static int exynos_video_phy_probe(struct platform_device *pdev)
+{
+struct exynos_video_phy *state;
+struct device *dev = pdev-dev;
+struct resource *res;
+struct phy_provider *phy_provider;
+int i;
+
+
On Wed, Jun 26, 2013 at 02:03:42PM +0200, Sylwester Nawrocki wrote:
On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote:
+static int exynos_video_phy_probe(struct platform_device *pdev)
+{
+ struct exynos_video_phy *state;
+ struct device *dev = pdev-dev;
+ struct resource *res;
On Wednesday 26 June 2013 05:52 PM, Felipe Balbi wrote:
On Wed, Jun 26, 2013 at 02:03:42PM +0200, Sylwester Nawrocki wrote:
On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote:
+static int exynos_video_phy_probe(struct platform_device *pdev)
+{
+ struct exynos_video_phy *state;
+
Hi,
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
+static struct platform_driver exynos_video_phy_driver = {
+ .probe = exynos_video_phy_probe,
you *must* provide a remove method. drivers with NULL remove are
non-removable :-)
Actually the remove() callback can be NULL, it's just missing
Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2
receiver and MIPI DSI transmitter DPHYs.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Changes since v1:
- enabled build as module and with CONFIG_OF disabled
Hi,
On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote:
+enum phy_id {
+ PHY_CSIS0,
+ PHY_DSIM0,
+ PHY_CSIS1,
+ PHY_DSIM1,
+ NUM_PHYS
please prepend these with EXYNOS_PHY_ or EXYNOS_MIPI_PHY_
+struct exynos_video_phy {
+ spinlock_t slock;
+
Hi Felipe,
Thanks for the review.
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote:
+enum phy_id {
+PHY_CSIS0,
+PHY_DSIM0,
+PHY_CSIS1,
+PHY_DSIM1,
+NUM_PHYS
please prepend these with EXYNOS_PHY_ or
Hi Sylwester, Felipe,
On Tuesday 25 of June 2013 19:44:52 Sylwester Nawrocki wrote:
Hi Felipe,
Thanks for the review.
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote:
+enum phy_id {
+ PHY_CSIS0,
+ PHY_DSIM0,
+
Hi,
On Tue, Jun 25, 2013 at 07:44:52PM +0200, Sylwester Nawrocki wrote:
+struct exynos_video_phy {
+ spinlock_t slock;
+ struct phy *phys[NUM_PHYS];
more than one phy ? This means you should instantiate driver multiple
drivers. Each phy id should call probe again.
Why ? This
Hi,
On 06/25/2013 10:54 PM, Felipe Balbi wrote:
+static int exynos_video_phy_probe(struct platform_device *pdev)
+{
+ struct exynos_video_phy *state;
+ struct device *dev =pdev-dev;
+ struct resource *res;
+ struct phy_provider *phy_provider;
+
On Tue, Jun 25, 2013 at 11:47:13PM +0200, Sylwester Nawrocki wrote:
Hi,
On 06/25/2013 10:54 PM, Felipe Balbi wrote:
+static int exynos_video_phy_probe(struct platform_device *pdev)
+{
+ struct exynos_video_phy *state;
+ struct device *dev =pdev-dev;
+ struct resource
16 matches
Mail list logo