Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-08 Thread Inki Dae
2014-04-08 0:40 GMT+09:00, Tomasz Figa tomasz.f...@gmail.com: On 07.04.2014 17:16, Inki Dae wrote: Hi Andrzej, 2014-04-07 23:18 GMT+09:00 Andrzej Hajda a.ha...@samsung.com: Hi Inki and Tomasz, On 04/06/2014 05:15 AM, Inki Dae wrote: (...) The code creating the list of components to wait

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-07 Thread Andrzej Hajda
Hi Inki and Tomasz, On 04/06/2014 05:15 AM, Inki Dae wrote: (...) The code creating the list of components to wait for (exynos_drm_add_components()) doesn't seem to consider which sub-drivers are actually enabled in kernel config. Are you sure? exynos_drm_add_components() will try to

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-07 Thread Tomasz Figa
Hi Andrzej, On 07.04.2014 16:18, Andrzej Hajda wrote: Hi Inki and Tomasz, On 04/06/2014 05:15 AM, Inki Dae wrote: (...) The code creating the list of components to wait for (exynos_drm_add_components()) doesn't seem to consider which sub-drivers are actually enabled in kernel config. Are

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-07 Thread Inki Dae
Hi Andrzej, 2014-04-07 23:18 GMT+09:00 Andrzej Hajda a.ha...@samsung.com: Hi Inki and Tomasz, On 04/06/2014 05:15 AM, Inki Dae wrote: (...) The code creating the list of components to wait for (exynos_drm_add_components()) doesn't seem to consider which sub-drivers are actually enabled in

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-07 Thread Tomasz Figa
On 07.04.2014 17:16, Inki Dae wrote: Hi Andrzej, 2014-04-07 23:18 GMT+09:00 Andrzej Hajda a.ha...@samsung.com: Hi Inki and Tomasz, On 04/06/2014 05:15 AM, Inki Dae wrote: (...) The code creating the list of components to wait for (exynos_drm_add_components()) doesn't seem to consider which

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-06 Thread Russell King - ARM Linux
On Sun, Apr 06, 2014 at 01:21:24PM +0900, Inki Dae wrote: As you may know, there is exynos chip that has two display controllers. So it is possible to compose display pipe lines at same time like below, fimd0-bridges..--Panel fimd1-maybe bridges..-CPU Panel How we can

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-06 Thread Inki Dae
Hi Russell, 2014-04-06 17:47 GMT+09:00 Russell King - ARM Linux li...@arm.linux.org.uk: On Sun, Apr 06, 2014 at 01:21:24PM +0900, Inki Dae wrote: As you may know, there is exynos chip that has two display controllers. So it is possible to compose display pipe lines at same time like below,

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Tomasz Figa
[adding more people and MLs on Cc for further discussion] On 04.04.2014 17:44, Inki Dae wrote: 2014-04-04 22:55 GMT+09:00 Tomasz Figa t.f...@samsung.com: Hi Inki, On 01.04.2014 14:37, Inki Dae wrote: This patch adds super device support to bind sub drivers using device tree. For this, you

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Tomasz Figa
On 05.04.2014 20:24, Russell King - ARM Linux wrote: On Sat, Apr 05, 2014 at 07:32:50PM +0200, Tomasz Figa wrote: Not exactly. The approach we found does mostly the same as componentized subsystem framework but without _any_ extra data in Device Tree. Just based on the list of subsystem

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Russell King - ARM Linux
On Sat, Apr 05, 2014 at 08:31:15PM +0200, Tomasz Figa wrote: Maybe my words have been misinterpreted, but all I'm suggesting here is that there is no need to add any new data to DT to solve the same issue to the same extent as componentized subsystem framework, at least in Exynos case.

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Tomasz Figa
On 05.04.2014 20:52, Russell King - ARM Linux wrote: On Sat, Apr 05, 2014 at 08:31:15PM +0200, Tomasz Figa wrote: Maybe my words have been misinterpreted, but all I'm suggesting here is that there is no need to add any new data to DT to solve the same issue to the same extent as componentized

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Inki Dae
I'd be really happy if you gave me such opinions before pull request. Anyway, below is my comments. 2014-04-06 2:32 GMT+09:00 Tomasz Figa tomasz.f...@gmail.com: [adding more people and MLs on Cc for further discussion] On 04.04.2014 17:44, Inki Dae wrote: 2014-04-04 22:55 GMT+09:00 Tomasz

Re: [PATCH v2 1/7] drm/exynos: add super device support

2014-04-05 Thread Inki Dae
2014-04-06 3:31 GMT+09:00, Tomasz Figa tomasz.f...@gmail.com: On 05.04.2014 20:24, Russell King - ARM Linux wrote: On Sat, Apr 05, 2014 at 07:32:50PM +0200, Tomasz Figa wrote: Not exactly. The approach we found does mostly the same as componentized subsystem framework but without _any_ extra