Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-19 Thread Thomas Abraham
Hi Darius, On 19 March 2012 05:16, Jingoo Han jg1@samsung.com wrote: [...] Because there are not multiple windows and driver sees only single window as you mentiond, Only 'struct s3c_fb_pd_win mini6410_fb_win[0]' should be used and 'struct s3c_fb_pd_win mini6410_fb_win[1]' should not

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-19 Thread Darius Augulis
Hi, On Mon, Mar 19, 2012 at 9:29 AM, Thomas Abraham thomas.abra...@linaro.org wrote: Hi Darius, On 19 March 2012 05:16, Jingoo Han jg1@samsung.com wrote: [...] Because there are not multiple windows and driver sees only single window as you mentiond, Only 'struct s3c_fb_pd_win

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-19 Thread Thomas Abraham
On 19 March 2012 13:10, Darius Augulis augulis.dar...@gmail.com wrote: Hi, On Mon, Mar 19, 2012 at 9:29 AM, Thomas Abraham thomas.abra...@linaro.org wrote: Hi Darius, On 19 March 2012 05:16, Jingoo Han jg1@samsung.com wrote: [...] Because there are not multiple windows and driver

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-19 Thread Darius Augulis
On Mon, Mar 19, 2012 at 9:49 AM, Thomas Abraham thomas.abra...@linaro.org wrote: On 19 March 2012 13:10, Darius Augulis augulis.dar...@gmail.com wrote: Right now s3c_fb_pd_win contains exactly LCD timing values. Your patch will move these timing values to struct fb_videomode. I could make

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-18 Thread Jingoo Han
: Rework platform data of s3c-fb driver On Fri, Mar 16, 2012 at 11:48 AM, Jingoo Han jg1@samsung.com wrote: It's just bug. struct s3c_fb_pd_win should be used for windows of FIMD IP. It should not be used for selecting multi-LCDs. why not? s3c_fb_pd_win contains timing values

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-16 Thread Darius Augulis
On Fri, Mar 16, 2012 at 3:39 AM, Jingoo Han jg1@samsung.com wrote: So, your code can be removed. I don't think so. It does not break anything yet. One who make changes, should ensure backwards compatibility, at least talking about functionality and hardware (LCD) support, which was

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-16 Thread Jingoo Han
-li...@fluff.org; patc...@linaro.org; kgene@samsung.com; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Maurus Cuelenaere; Tushar Behera Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver On Fri, Mar 16, 2012 at 3

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-16 Thread Darius Augulis
: Samsung: Rework platform data of s3c-fb driver On Fri, Mar 16, 2012 at 3:39 AM, Jingoo Han jg1@samsung.com wrote: it's not a bug, because it's working like it was intended to. it was reviewed and accepted by maintainers before merging to main line. you do not have rights to drop it because you

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-16 Thread Jingoo Han
-li...@fluff.org; patc...@linaro.org; kgene@samsung.com; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Maurus Cuelenaere; Tushar Behera Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver On Fri, Mar 16, 2012 at 10

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-16 Thread Darius Augulis
On Fri, Mar 16, 2012 at 11:48 AM, Jingoo Han jg1@samsung.com wrote: It's just bug. struct s3c_fb_pd_win should be used for windows of FIMD IP. It should not be used for selecting multi-LCDs. why not? s3c_fb_pd_win contains timing values which depend directly on LCD size and

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-15 Thread Darius Augulis
Hi, Yes, only single LCD resolution will be left. I have mini6410 with both 4.3 and 7 LCDs and real6410 with 7 LCD. Now we have possibility to choose LCD size dynamically - leave it there. What you mean default 4.3 size LCD? The 7 size LCD is also provided by board sellers - I've bought

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-15 Thread Jingoo Han
; kgene@samsung.com; ben- li...@fluff.org; patc...@linaro.org; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Maurus Cuelenaere Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver Hi, Yes, only single LCD

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-15 Thread Darius Augulis
On Thu, Mar 15, 2012 at 10:10 AM, Jingoo Han jg1@samsung.com wrote: There is single board - mini6410 (or real6410) and it's name doesn't depend on connected LCD size. We know, that this board is available with different sizes of LCD and currently we have in kernel support for both sizes.

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-15 Thread Jingoo Han
; kgene@samsung.com; ben- li...@fluff.org; patc...@linaro.org; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Maurus Cuelenaere Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver On Thu, Mar 15, 2012 at 10:10 AM

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-15 Thread Jingoo Han
; kgene@samsung.com; ben- li...@fluff.org; patc...@linaro.org; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Maurus Cuelenaere Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver On Thu, Mar 15, 2012 at 10:10 AM

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-14 Thread Darius Augulis
-...@vger.kernel.org; kgene@samsung.com; ben-li...@fluff.org; patc...@linaro.org; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Darius Augulis; Maurus Cuelenaere Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver On 13 March

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-14 Thread Darius Augulis
3/3] ARM: Samsung: Rework platform data of s3c-fb driver For all the Samsung SoC based boards which have the platform data for s3c-fb driver, the 'default_win' element in the platform data is removed and the lcd panel video timing values are moved out of individual window configuration data. Cc

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-14 Thread Jingoo Han
; kgene@samsung.com; ben- li...@fluff.org; patc...@linaro.org; 'Kyungmin Park'; 'JeongHyeon Kim'; 'Heiko Stuebner'; 'Kwangwoo Lee'; 'Mark Brown'; 'Peter Korsgaard'; 'Maurus Cuelenaere' Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver On 03/14/2012 03:51 AM

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-13 Thread Jingoo Han
@samsung.com; ben-li...@fluff.org; patc...@linaro.org; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Darius Augulis; Maurus Cuelenaere Subject: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver For all the Samsung SoC based boards

Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-13 Thread Thomas Abraham
-samsung-soc@vger.kernel.org; kgene@samsung.com; jg1@samsung.com; ben-li...@fluff.org; patc...@linaro.org; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Darius Augulis; Maurus Cuelenaere Subject: [PATCH v2 3/3] ARM: Samsung: Rework platform

RE: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-13 Thread Jingoo Han
; ben-li...@fluff.org; patc...@linaro.org; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark Brown; Peter Korsgaard; Darius Augulis; Maurus Cuelenaere Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver On 13 March 2012 15:17, Jingoo Han jg1

[PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver

2012-03-12 Thread Thomas Abraham
For all the Samsung SoC based boards which have the platform data for s3c-fb driver, the 'default_win' element in the platform data is removed and the lcd panel video timing values are moved out of individual window configuration data. Cc: Jingoo Han jg1@samsung.com Cc: Kyungmin Park