Re: [PATCH v2 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-29 Thread Javier Martinez Canillas
Hello Ulf, Thanks a lot for your feedback. On 01/29/2015 02:05 PM, Ulf Hansson wrote: >> >> struct mmc_pwrseq_simple { >> struct mmc_pwrseq pwrseq; >> + struct clk *ext_clk; > > You need to add a bool, maybe call it clk_enabled; See why below. > Ok >> int nr_gpios; >>

Re: [PATCH v2 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-29 Thread Ulf Hansson
On 28 January 2015 at 19:15, Javier Martinez Canillas wrote: > Some WLAN chips attached to a SDIO interface, need a reference clock. > > Since this is very common, extend the prseq_simple driver to support > an optional clock that is enabled prior the card power up procedure. > > Note: the externa

[PATCH v2 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-28 Thread Javier Martinez Canillas
Some WLAN chips attached to a SDIO interface, need a reference clock. Since this is very common, extend the prseq_simple driver to support an optional clock that is enabled prior the card power up procedure. Note: the external clock is optional. Thus an error is not returned if the clock is not f