Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-04-07 Thread Jingoo Han
On Monday, April 07, 2014 5:39 PM, Lucas Stach wrote: > Am Freitag, den 04.04.2014, 11:05 -0600 schrieb Bjorn Helgaas: > > On Fri, Apr 04, 2014 at 11:03:41AM -0600, Bjorn Helgaas wrote: > > > On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: > > > > On Wed, Mar 05, 2014 at 02:25:51PM

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-04-07 Thread Lucas Stach
Hi Bjorn, Am Freitag, den 04.04.2014, 11:05 -0600 schrieb Bjorn Helgaas: > On Fri, Apr 04, 2014 at 11:03:41AM -0600, Bjorn Helgaas wrote: > > On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: > > > On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: > > > > - return p

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-04-04 Thread Bjorn Helgaas
On Fri, Apr 04, 2014 at 11:03:41AM -0600, Bjorn Helgaas wrote: > On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: > > On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: > > > - return pp->irq; > > > + irq = of_irq_parse_and_map_pci(dev, slot, pin); > > > + if (!irq) > > >

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-04-04 Thread Bjorn Helgaas
On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: > On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: > > - return pp->irq; > > + irq = of_irq_parse_and_map_pci(dev, slot, pin); > > + if (!irq) > > + irq = pp->irq; > > In light of the two bugs that Tim fou

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-13 Thread Tim Harvey
On Thu, Mar 6, 2014 at 7:33 AM, Marek Vasut wrote: > On Thursday, March 06, 2014 at 03:47:03 AM, Jingoo Han wrote: >> On Wednesday, March 05, 2014 10:26 PM, Lucas Stach wrote: >> > This is the recommended method of doing the IRQ >> > mapping. For old devicetrees we fall back to the >> > previous p

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-06 Thread Marek Vasut
On Thursday, March 06, 2014 at 03:47:03 AM, Jingoo Han wrote: > On Wednesday, March 05, 2014 10:26 PM, Lucas Stach wrote: > > This is the recommended method of doing the IRQ > > mapping. For old devicetrees we fall back to the > > previous practice. > > > > Signed-off-by: Lucas Stach > > Acked-by

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-05 Thread Jingoo Han
On Wednesday, March 05, 2014 10:26 PM, Lucas Stach wrote: > > This is the recommended method of doing the IRQ > mapping. For old devicetrees we fall back to the > previous practice. > > Signed-off-by: Lucas Stach > Acked-by: Arnd Bergmann (+cc Mohit KUMAR, Richard Zhu, Pratyush Anand, Marek Va

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-05 Thread Jason Gunthorpe
On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: > - return pp->irq; > + irq = of_irq_parse_and_map_pci(dev, slot, pin); > + if (!irq) > + irq = pp->irq; In light of the two bugs that Tim found, it might be wise to throw a 'dev_warn(FW_BUG "Missing DT interrupt

[PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-05 Thread Lucas Stach
This is the recommended method of doing the IRQ mapping. For old devicetrees we fall back to the previous practice. Signed-off-by: Lucas Stach Acked-by: Arnd Bergmann --- v2: pass in parent dev to relevant functions, to make DT parsing work (spotted by Tim Harvey ) --- drivers/pci/host/pcie