Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-08-01 Thread Greg KH
On Wed, Jul 31, 2013 at 04:44:43PM -0400, Alan Stern wrote: > On Wed, 31 Jul 2013, Tomasz Figa wrote: > > > Alan, Greg, > > > > On Tuesday 23 of July 2013 01:49:23 Tomasz Figa wrote: > > > This patch modifies the ohci-s3c2410 driver to prepare and unprepare > > > clocks in addition to enabling an

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-07-31 Thread Alan Stern
On Wed, 31 Jul 2013, Tomasz Figa wrote: > Alan, Greg, > > On Tuesday 23 of July 2013 01:49:23 Tomasz Figa wrote: > > This patch modifies the ohci-s3c2410 driver to prepare and unprepare > > clocks in addition to enabling and disabling, since it is required > > by common clock framework. > > > >

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-07-31 Thread Tomasz Figa
Alan, Greg, On Tuesday 23 of July 2013 01:49:23 Tomasz Figa wrote: > This patch modifies the ohci-s3c2410 driver to prepare and unprepare > clocks in addition to enabling and disabling, since it is required > by common clock framework. > > Signed-off-by: Tomasz Figa > --- > drivers/usb/host/ohc

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-07-22 Thread Tomasz Figa
On Monday 22 of July 2013 21:15:12 Fabio Estevam wrote: > On Mon, Jul 22, 2013 at 8:49 PM, Tomasz Figa wrote: > > dev_dbg(&dev->dev, "s3c2410_start_hc:\n"); > > > > - clk_enable(usb_clk); > > + clk_prepare_enable(usb_clk); > > clk_prepare_enable may fail, so you would bette

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-07-22 Thread Fabio Estevam
On Mon, Jul 22, 2013 at 8:49 PM, Tomasz Figa wrote: > dev_dbg(&dev->dev, "s3c2410_start_hc:\n"); > > - clk_enable(usb_clk); > + clk_prepare_enable(usb_clk); clk_prepare_enable may fail, so you would better check its return value. -- To unsubscribe from this list: send the li

[PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-07-22 Thread Tomasz Figa
This patch modifies the ohci-s3c2410 driver to prepare and unprepare clocks in addition to enabling and disabling, since it is required by common clock framework. Signed-off-by: Tomasz Figa --- drivers/usb/host/ohci-s3c2410.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --