Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-23 Thread Tobias Jakobi
Eduardo Valentin wrote: > The reason is that hwmon sensor device drivers also register via > of-thermal. So, adding hwmon interface by default will create a > cyclic problem. Hmm, I see. Would it still be possible to flag some thermal zones so that hwmon nodes are created for them? With best wish

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-22 Thread Eduardo Valentin
On Thu, Jan 22, 2015 at 02:06:10AM +0100, Tobias Jakobi wrote: > Hello! > > > Lukasz Majewski wrote: > >> The point is that I'm still working with a rather old version of the > >> cpufreq series, a version which still had the Exynos4x12 code in it > >> (this was removed later, if I remember corre

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-21 Thread Tobias Jakobi
Hello! Lukasz Majewski wrote: >> The point is that I'm still working with a rather old version of the >> cpufreq series, a version which still had the Exynos4x12 code in it >> (this was removed later, if I remember correctly because of problems >> with how to properly describe boost configuration

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-20 Thread Lukasz Majewski
Hi Tobias, > Hello! > > Lukasz Majewski wrote: > > We all know that this code is floating around - early version of > > this work was posted in the Q3 2013. > > > > To be fair - this code is both needed and welcome, but new problems > > with it are found (please search for recent comment from Ke

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-19 Thread Tobias Jakobi
Hello! Lukasz Majewski wrote: > We all know that this code is floating around - early version of this > work was posted in the Q3 2013. > > To be fair - this code is both needed and welcome, but new problems > with it are found (please search for recent comment from Kevin > Hilman). > > From my

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-16 Thread Lukasz Majewski
Hi Tobias, > Hello, > > while looking through the patchset I noticed the following. In patch > 07/16 code is added to drivers/cpufreq/exynos-cpufreq.c, which > reminded me of the cpufreq patchset by Thomas Abraham. We all know that this code is floating around - early version of this work was p

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-15 Thread Tobias Jakobi
Hello, while looking through the patchset I noticed the following. In patch 07/16 code is added to drivers/cpufreq/exynos-cpufreq.c, which reminded me of the cpufreq patchset by Thomas Abraham. If I remember correctly then the ultimate goal of the cpufreq 'conversion' is to get rid of the exynos-c

[PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-14 Thread Lukasz Majewski
1. Introduction Following patches aim to clean up the current implementation of the thermal framework on Exynos devices. The main goal was to use a generic code for reading thermal configuration (of-thermal.c). Due to that redundant exynos_thermal_common.[h|c] files were removed. Around 400 line