Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-25 Thread Javier Martinez Canillas
Hello Doug, Thanks a lot for your feedback. On 06/25/2014 08:06 PM, Doug Anderson wrote: > Javier, > > On Thu, Jun 19, 2014 at 11:20 AM, Javier Martinez Canillas > wrote: >> @@ -33,6 +38,6 @@ Example: Clock consumer node >> foo@0 { >> compatible = "bar,foo"; >>

Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-25 Thread Doug Anderson
Javier, On Thu, Jun 19, 2014 at 11:20 AM, Javier Martinez Canillas wrote: > @@ -33,6 +38,6 @@ Example: Clock consumer node > foo@0 { > compatible = "bar,foo"; > /* ... */ > - clock-names = "my-clock"; > - clocks = <&max77686 2>;

Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-25 Thread Krzysztof Kozlowski
On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote: > Like most clock drivers, the Maxim 77686 PMIC clock binding > follows the convention that the "#clock-cells" property is > used to specify the number of cells in a clock provider. > > But the binding document is not clear enough

[PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-19 Thread Javier Martinez Canillas
Like most clock drivers, the Maxim 77686 PMIC clock binding follows the convention that the "#clock-cells" property is used to specify the number of cells in a clock provider. But the binding document is not clear enough that it shall be set to 1 since the PMIC support multiple clocks outputs. Al