Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-23 Thread Javier Martinez Canillas
Hello Varka, Thanks a lot for your feedback. On 01/23/2015 04:57 AM, Varka Bhadram wrote: (...) +static int cros_ec_lpc_probe(struct platform_device *pdev) +{ + struct device *dev = pdev-dev; + struct cros_ec_device *ec_dev; + int err = -ENOTTY; + + if

Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Varka Bhadram
On Fri, Jan 23, 2015 at 12:46 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: From: Bill Richardson wfric...@chromium.org Chromebooks have an Embedded Controller (EC) that is used to implement various functions such as keyboard, power and battery. The AP can communicate

[PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Javier Martinez Canillas
From: Bill Richardson wfric...@chromium.org Chromebooks have an Embedded Controller (EC) that is used to implement various functions such as keyboard, power and battery. The AP can communicate with the EC through different bus types such as I2C, SPI or LPC. The cros_ec mfd driver is then