Re: [PATCH v3 5/7] ARM: S5PV210: macros for clock registers at regs-clock.h

2010-07-20 Thread MyungJoo Ham
On Wed, Jul 21, 2010 at 9:38 AM, Ben Dooks wrote: > On 07/19/10 06:31, MyungJoo Ham wrote: >> >> Previously, most of CLK_DIV/SRC register accessing mask and shift >> values were used at arch/arm/mach-s5pv210/clock.c only; thus we >> had not been using macros for these. However, as CPUFREQ uses >>

Re: [PATCH v3 5/7] ARM: S5PV210: macros for clock registers at regs-clock.h

2010-07-20 Thread Ben Dooks
On 07/19/10 06:31, MyungJoo Ham wrote: Previously, most of CLK_DIV/SRC register accessing mask and shift values were used at arch/arm/mach-s5pv210/clock.c only; thus we had not been using macros for these. However, as CPUFREQ uses those shift and mask values as well, we'd better define them at a

[PATCH v3 5/7] ARM: S5PV210: macros for clock registers at regs-clock.h

2010-07-18 Thread MyungJoo Ham
Previously, most of CLK_DIV/SRC register accessing mask and shift values were used at arch/arm/mach-s5pv210/clock.c only; thus we had not been using macros for these. However, as CPUFREQ uses those shift and mask values as well, we'd better define them at a single location, whose proper location wo