RE: [PATCH v4] mfd: syscon: Decouple syscon interface from platform devices

2014-09-21 Thread Pankaj Dubey
Hi Tomasz, On Friday, September 19, 2014 Tomasz Figa wrote, > Hi Pankaj, > > Please see my comments inline. > > On 19.09.2014 15:06, Pankaj Dubey wrote: > > Currently a syscon entity can be only registered directly through a > > platform device that binds to a dedicated syscon driver. However in

Re: [PATCH v4] mfd: syscon: Decouple syscon interface from platform devices

2014-09-19 Thread Tomasz Figa
On 19.09.2014 17:11, Tomasz Figa wrote: >> + >> +if (!of_device_is_available(np) || > > Wouldn't it be enough to simply call of_find_device_by_node(np) and if > it fails then instead create a dummy device? > >> +of_node_test_and_set_flag(np, OF_POPULATED)) { One more thin

Re: [PATCH v4] mfd: syscon: Decouple syscon interface from platform devices

2014-09-19 Thread Tomasz Figa
Hi Pankaj, Please see my comments inline. On 19.09.2014 15:06, Pankaj Dubey wrote: > Currently a syscon entity can be only registered directly through a > platform device that binds to a dedicated syscon driver. However in > certain use cases it is desirable to make a device used with another > d

Re: [PATCH v4] mfd: syscon: Decouple syscon interface from platform devices

2014-09-19 Thread Javier Martinez Canillas
Hello Pankaj, On Fri, Sep 19, 2014 at 3:06 PM, Pankaj Dubey wrote: > Currently a syscon entity can be only registered directly through a > platform device that binds to a dedicated syscon driver. However in > certain use cases it is desirable to make a device used with another > driver a syscon i

[PATCH v4] mfd: syscon: Decouple syscon interface from platform devices

2014-09-19 Thread Pankaj Dubey
Currently a syscon entity can be only registered directly through a platform device that binds to a dedicated syscon driver. However in certain use cases it is desirable to make a device used with another driver a syscon interface provider. For example, certain SoCs (e.g. Exynos) contain system co