[PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data()

2014-11-03 Thread Javier Martinez Canillas
The of_get_regulator_init_data() function is used to extract the regulator init_data but information on how to extract certain data is defined in the static regulator descriptor (e.g: how to map the hardware operating modes). Add a const struct regulator_desc * parameter to the function signature

Re: [PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data()

2014-11-03 Thread Mark Brown
On Mon, Nov 03, 2014 at 03:40:38PM +0100, Javier Martinez Canillas wrote: for_each_child_of_node(nproot, np) { if (!of_node_cmp(np-name, info-desc.name)) { config-init_data = - of_get_regulator_init_data(pdev-dev, np); +

Re: [PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data()

2014-11-03 Thread Javier Martinez Canillas
On 11/03/2014 04:33 PM, Mark Brown wrote: On Mon, Nov 03, 2014 at 03:40:38PM +0100, Javier Martinez Canillas wrote: for_each_child_of_node(nproot, np) { if (!of_node_cmp(np-name, info-desc.name)) { config-init_data = -

Re: [PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data()

2014-11-03 Thread Mark Brown
On Mon, Nov 03, 2014 at 04:48:34PM +0100, Javier Martinez Canillas wrote: On 11/03/2014 04:33 PM, Mark Brown wrote: On Mon, Nov 03, 2014 at 03:40:38PM +0100, Javier Martinez Canillas wrote: if (!of_node_cmp(np-name, info-desc.name)) { config-init_data = -

Re: [PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data()

2014-11-03 Thread Javier Martinez Canillas
On 11/03/2014 04:59 PM, Mark Brown wrote: No, it's only *currently* used for that. If we don't bother passing the descriptor in then future additions which make use of it (including adding mode operations to existing drivers) won't work and it might not be obvious why. fair enough.