Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
On 10 July 2012 22:27, Mark Brown wrote: > On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > >> In non-dt case, the platform code supplying the gpio number (slave >> select line) is responsible for requesting the gpio during the >> machine_init call. So the gpio request is not call

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Mark Brown
On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > In non-dt case, the platform code supplying the gpio number (slave > select line) is responsible for requesting the gpio during the > machine_init call. So the gpio request is not called in the driver for > that gpio. In dt case, th

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
On 10 July 2012 20:08, Mark Brown wrote: > On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree based discovery. Since a

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Mark Brown
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the sl

[PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a