Re: [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-23 Thread Lukasz Majewski
Hi Guenter, > On Mon, Feb 23, 2015 at 05:13:36PM +0100, Lukasz Majewski wrote: > > Hi Guenter, > > > [ ... ] > > > > > > > If devicetree is not configured, of_property_count_elems_of_size > > > returns -ENOSYS, which is returned, causing the driver to fail > > > loading. > > > > Has of_propert

Re: [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-23 Thread Guenter Roeck
On Mon, Feb 23, 2015 at 05:51:22PM +0100, Lukasz Majewski wrote: > Hi Guenter, > > > On Mon, Feb 23, 2015 at 05:13:36PM +0100, Lukasz Majewski wrote: > > > Hi Guenter, > > > > > [ ... ] > > > > > > > > > > If devicetree is not configured, of_property_count_elems_of_size > > > > returns -ENOSYS,

Re: [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-23 Thread Guenter Roeck
On Mon, Feb 23, 2015 at 05:13:36PM +0100, Lukasz Majewski wrote: > Hi Guenter, > [ ... ] > > > > If devicetree is not configured, of_property_count_elems_of_size > > returns -ENOSYS, which is returned, causing the driver to fail > > loading. > > Has of_property_count_elems_of_size() returns -EN

Re: [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-23 Thread Lukasz Majewski
Hi Guenter, > On 02/18/2015 02:07 AM, Lukasz Majewski wrote: > > This patch provides code for reading PWM FAN configuration data via > > device tree. The pwm-fan can work with full speed when configuration > > is not provided. However, errors are propagated when wrong DT > > bindings are found. >

Re: [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-20 Thread Guenter Roeck
On 02/18/2015 02:07 AM, Lukasz Majewski wrote: This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan

[PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-18 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz Ma