Re: [PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-14 Thread KyongHo Cho
On Fri, Oct 14, 2011 at 11:17 PM, Roedel, Joerg wrote: > On Thu, Oct 13, 2011 at 04:13:23AM -0400, KyongHo Cho wrote: >> +struct exynos_iommu_domain { >> +       struct device *dev; >> +       unsigned long *pgtable; >> +       spinlock_t lock; >> +       spinlock_t pgtablelock; >> +}; > > Can you

Re: [PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-14 Thread Roedel, Joerg
On Thu, Oct 13, 2011 at 04:13:23AM -0400, KyongHo Cho wrote: > +struct exynos_iommu_domain { > + struct device *dev; > + unsigned long *pgtable; > + spinlock_t lock; > + spinlock_t pgtablelock; > +}; Can you please add comments to document what these spinlocks protect? > +

[PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-13 Thread KyongHo Cho
This is the exactly same patch with the previous "[PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms". The only change from the previous one is to change Sylwester's email address in the Cc list by his request. Regards, KyongHo. commit e1ad653521025dec5888b9818

[PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-12 Thread KyongHo Cho
This is the System MMU driver and IOMMU API implementation for Exynos SOC platforms. Exynos platforms has more than 10 System MMUs dedicated for each multimedia accellerators. The System MMU driver is already in arc/arm/plat-s5p but it is moved to drivers/iommu due to Ohad Ben-Cohen gathered IOMMU