Re: [PATCH v5 2/4] regulator: max77686: Store opmode non-shifted

2014-10-28 Thread Mark Brown
On Mon, Oct 27, 2014 at 01:11:48PM +0100, Krzysztof Kozlowski wrote: Introduce simple helper for calculating the shift for OPMODE field in registers. This allows storing the current value of opmode in non-shifted form and simplifies a little set_suspend_disable and enable functions.

[PATCH v5 2/4] regulator: max77686: Store opmode non-shifted

2014-10-27 Thread Krzysztof Kozlowski
Introduce simple helper for calculating the shift for OPMODE field in registers. This allows storing the current value of opmode in non-shifted form and simplifies a little set_suspend_disable and enable functions. Additionally this will allow adding support LDOs to the existing

Re: [PATCH v5 2/4] regulator: max77686: Store opmode non-shifted

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 01:11 PM, Krzysztof Kozlowski wrote: Introduce simple helper for calculating the shift for OPMODE field in registers. This allows storing the current value of opmode in non-shifted form and simplifies a little set_suspend_disable and enable functions.

Re: [PATCH v5 2/4] regulator: max77686: Store opmode non-shifted

2014-10-27 Thread Krzysztof Kozlowski
On pon, 2014-10-27 at 14:37 +0100, Javier Martinez Canillas wrote: Hello Krzysztof, On 10/27/2014 01:11 PM, Krzysztof Kozlowski wrote: Introduce simple helper for calculating the shift for OPMODE field in registers. This allows storing the current value of opmode in non-shifted form and