Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-19 Thread Sylwester Nawrocki
Hi Guennadi, On 03/19/2013 08:32 AM, Guennadi Liakhovetski wrote: > On Mon, 18 Mar 2013, Sylwester Nawrocki wrote: >> On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote: [...] >>> diff --git a/drivers/media/v4l2-core/v4l2-clk.c >>> b/drivers/media/v4l2-core/v4l2-clk.c >>> new file mode 100644 >>>

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-19 Thread Guennadi Liakhovetski
On Tue, 19 Mar 2013, Sylwester Nawrocki wrote: > >>> + if (!IS_ERR(clk)&& !try_module_get(clk->ops->owner)) > >>> + clk = ERR_PTR(-ENODEV); > >>> + mutex_unlock(&clk_lock); > >>> + > >>> + if (!IS_ERR(clk)) { > >>> + clk->subdev = sd; > >> > >> Why is this needed ? It seems a stra

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-26 Thread Laurent Pinchart
Hello, On Tuesday 19 March 2013 10:52:29 Sylwester Nawrocki wrote: > On 03/19/2013 08:32 AM, Guennadi Liakhovetski wrote: > > On Mon, 18 Mar 2013, Sylwester Nawrocki wrote: > >> On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote: > [...] > > >>> diff --git a/drivers/media/v4l2-core/v4l2-clk.c >

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-26 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 19 March 2013 11:27:56 Guennadi Liakhovetski wrote: > On Tue, 19 Mar 2013, Sylwester Nawrocki wrote: > > >>> + if (!IS_ERR(clk)&& !try_module_get(clk->ops->owner)) > > >>> + clk = ERR_PTR(-ENODEV); > > >>> + mutex_unlock(&clk_lock); > > >>> + > >