Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-30 Thread Thierry Reding
On Wed, Jul 30, 2014 at 04:44:21PM +0300, Tomi Valkeinen wrote: > On 22/07/14 10:49, Thierry Reding wrote: > > > But what I was trying to say is that if the Read IDs command isn't an > > official DCS command, maybe it would be a better idea to use the DDB > > instead. I assume that even if it isn'

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-30 Thread Tomi Valkeinen
On 22/07/14 10:49, Thierry Reding wrote: > But what I was trying to say is that if the Read IDs command isn't an > official DCS command, maybe it would be a better idea to use the DDB > instead. I assume that even if it isn't the same information it would > at least be a superset and therefore a s

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-30 Thread Tomi Valkeinen
On 22/07/14 06:41, YoungJun Cho wrote: > Yes, this command is related with Nokia. > > Last Friday, I met panel vendor guy for some issues. > At the break time, I asked him for about this Read IDs(04H), why it is > not included in DCS specification. > He said that this command was originated by No

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-29 Thread YoungJun Cho
Hi Thierry, Sorry for late reply. I implemented common DSI helper functions and tested in s6e3fa0 panel (I should test with other panels). The helper function prototypes are like below: int mipi_dsi_set_maximum_return_packet_size(struct mipi_dsi_device *dsi,

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-22 Thread YoungJun Cho
Hi Thierry, On 07/22/2014 04:49 PM, Thierry Reding wrote: On Tue, Jul 22, 2014 at 12:41:21PM +0900, YoungJun Cho wrote: On 07/21/2014 08:18 PM, Andrzej Hajda wrote: On 07/21/2014 11:19 AM, Thierry Reding wrote: On Mon, Jul 21, 2014 at 10:56:08AM +0200, Andrzej Hajda wrote: On 07/18/2014 03:4

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-22 Thread Thierry Reding
On Tue, Jul 22, 2014 at 12:41:21PM +0900, YoungJun Cho wrote: > On 07/21/2014 08:18 PM, Andrzej Hajda wrote: > >On 07/21/2014 11:19 AM, Thierry Reding wrote: > >>On Mon, Jul 21, 2014 at 10:56:08AM +0200, Andrzej Hajda wrote: > >>>On 07/18/2014 03:49 AM, YoungJun Cho wrote: > On 07/17/2014 07:36

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-21 Thread YoungJun Cho
Hi Thierry, Now I understand what you mean. I'll implement common DSI helper functions. Thank you. Best regards YJ On 07/21/2014 06:35 PM, Thierry Reding wrote: On Fri, Jul 18, 2014 at 10:49:35AM +0900, YoungJun Cho wrote: Hi Thierry, Thank you a lot for kind comments. On 07/17/2014 07:36

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-21 Thread YoungJun Cho
Hi, On 07/21/2014 08:18 PM, Andrzej Hajda wrote: On 07/21/2014 11:19 AM, Thierry Reding wrote: On Mon, Jul 21, 2014 at 10:56:08AM +0200, Andrzej Hajda wrote: On 07/18/2014 03:49 AM, YoungJun Cho wrote: Hi Thierry, Thank you a lot for kind comments. On 07/17/2014 07:36 PM, Thierry Reding wro

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-21 Thread Andrzej Hajda
On 07/21/2014 11:19 AM, Thierry Reding wrote: > On Mon, Jul 21, 2014 at 10:56:08AM +0200, Andrzej Hajda wrote: >> On 07/18/2014 03:49 AM, YoungJun Cho wrote: >>> Hi Thierry, >>> >>> Thank you a lot for kind comments. >>> >>> On 07/17/2014 07:36 PM, Thierry Reding wrote: On Thu, Jul 17, 2014 at

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-21 Thread Thierry Reding
On Fri, Jul 18, 2014 at 10:49:35AM +0900, YoungJun Cho wrote: > Hi Thierry, > > Thank you a lot for kind comments. > > On 07/17/2014 07:36 PM, Thierry Reding wrote: > > On Thu, Jul 17, 2014 at 06:01:25PM +0900, YoungJun Cho wrote: [...] > > >diff --git a/drivers/gpu/drm/panel/panel-s6e3fa0.c > >

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-21 Thread Thierry Reding
On Mon, Jul 21, 2014 at 10:56:08AM +0200, Andrzej Hajda wrote: > On 07/18/2014 03:49 AM, YoungJun Cho wrote: > > Hi Thierry, > > > > Thank you a lot for kind comments. > > > > On 07/17/2014 07:36 PM, Thierry Reding wrote: > >> On Thu, Jul 17, 2014 at 06:01:25PM +0900, YoungJun Cho wrote: > >> [...]

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-21 Thread Andrzej Hajda
On 07/18/2014 03:49 AM, YoungJun Cho wrote: > Hi Thierry, > > Thank you a lot for kind comments. > > On 07/17/2014 07:36 PM, Thierry Reding wrote: >> On Thu, Jul 17, 2014 at 06:01:25PM +0900, YoungJun Cho wrote: >> [...] >>> diff --git a/drivers/gpu/drm/panel/panel-s6e3fa0.c >>> b/drivers/gpu/drm/

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-17 Thread YoungJun Cho
Hi Thierry, Thank you a lot for kind comments. On 07/17/2014 07:36 PM, Thierry Reding wrote: On Thu, Jul 17, 2014 at 06:01:25PM +0900, YoungJun Cho wrote: [...] diff --git a/drivers/gpu/drm/panel/panel-s6e3fa0.c b/drivers/gpu/drm/panel/panel-s6e3fa0.c [...] +/* Manufacturer Command Set */ +

Re: [PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 06:01:25PM +0900, YoungJun Cho wrote: [...] > diff --git a/drivers/gpu/drm/panel/panel-s6e3fa0.c > b/drivers/gpu/drm/panel/panel-s6e3fa0.c [...] > +/* Manufacturer Command Set */ > +#define MCS_GLOBAL_PARAMETER 0xb0 > +#define MCS_AID 0xb2 > +#define MC

[PATCH v6 10/14] drm/panel: add S6E3FA0 driver

2014-07-17 Thread YoungJun Cho
This patch adds MIPI DSI command mode based S6E3FA0 AMOLED LCD Panel driver. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-s6e3fa0.c | 541