Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2013-01-08 Thread Praveen Paneri
Hi Tomasz, Sorry! I I missed this comment of yours. Is it okay if we keep pmu_isolation as it is (as it does not seem much out of the line). We have already gone through a lot of rework and there has been no fruitful result :( Also after Viveks work, this is only milited to non DT SoCs. Thanks,

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-28 Thread Tomasz Figa
Hi Praveen, On Friday 23 of November 2012 09:56:37 Praveen Paneri wrote: +static void samsung_usbphy_enable(struct samsung_usbphy *sphy) +{ + void __iomem *regs = sphy-regs; + u32 phypwr; + u32 phyclk; + u32 rstcon; + + /* set clock frequency for PLL */ +

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-22 Thread Praveen Paneri
Hi Tomasz, On Thu, Nov 22, 2012 at 1:36 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Praveen, See some minor comments inline. Thanks for your comments On Wednesday 14 of November 2012 15:57:15 Praveen Paneri wrote: This driver uses usb_phy interface to interact with s3c-hsotg. Supports

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-21 Thread Tomasz Figa
Hi Praveen, See some minor comments inline. On Wednesday 14 of November 2012 15:57:15 Praveen Paneri wrote: This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init and phy_shutdown functions to enable/disable usb phy. Support will be extended to host controllers and

[PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-14 Thread Praveen Paneri
This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init and phy_shutdown functions to enable/disable usb phy. Support will be extended to host controllers and more Samsung SoCs. Signed-off-by: Praveen Paneri p.pan...@samsung.com Acked-by: Heiko Stuebner he...@sntech.de