Re: [PATCH v9] i2c: exynos5: add High Speed I2C controller driver

2013-06-10 Thread Wolfram Sang
Hi Naveen, > +Optional properties: > + - samsung,hs-mode: Mode of operation, High speed or Fast speed mode. If not > +specified, default value is 0. This was probably overlooked from my last review: Why can't you simply enable hs-mode when clock-frequency is > 1MBit? > +Example: > + > +hsi2

Re: [PATCH v9] i2c: exynos5: add High Speed I2C controller driver

2013-06-10 Thread Naveen Krishna Ch
On 17 May 2013 15:40, Naveen Krishna Chatradhi wrote: > > Adds support for High Speed I2C driver found in Exynos5 and > later SoCs from Samsung. > > Driver only supports Device Tree method. > > Changes since v1: > 1. Added FIFO functionality > 2. Added High speed mode functionality > 3. Remove SMB

Re: [PATCH v9] i2c: exynos5: add High Speed I2C controller driver

2013-05-22 Thread Naveen Krishna Ch
On 17 May 2013 15:40, Naveen Krishna Chatradhi wrote: > Adds support for High Speed I2C driver found in Exynos5 and > later SoCs from Samsung. > > Driver only supports Device Tree method. > > Changes since v1: > 1. Added FIFO functionality > 2. Added High speed mode functionality > 3. Remove SMBUS

[PATCH v9] i2c: exynos5: add High Speed I2C controller driver

2013-05-17 Thread Naveen Krishna Chatradhi
Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. Driver only supports Device Tree method. Changes since v1: 1. Added FIFO functionality 2. Added High speed mode functionality 3. Remove SMBUS_QUICK 4. Remove the debugfs functionality 5. Use devm_* functions wher