Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Viresh Kumar
On 21 January 2015 at 11:42, Chanwoo Choi wrote: > OK, I understand. > I'll try to update exynos memory bus according to your comment. Great. @Rob: So there is nothing special required for devfreq drivers in new OPP bindings, right ? :) -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Chanwoo Choi
On 01/21/2015 01:37 PM, Viresh Kumar wrote: > On 21 January 2015 at 09:50, Chanwoo Choi wrote: >> If the clock will be stayed on highest voltage, will reduce >> the considerable benefit of power-consumption. > > But this is exactly what you must be doing right now as well.. > I think I didn't mak

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Viresh Kumar
On 21 January 2015 at 09:50, Chanwoo Choi wrote: > If the clock will be stayed on highest voltage, will reduce > the considerable benefit of power-consumption. But this is exactly what you must be doing right now as well.. I think I didn't make it clear enough with an example. Let me try.. This

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Chanwoo Choi
On 01/21/2015 12:17 PM, Viresh Kumar wrote: > On 20 January 2015 at 17:07, Chanwoo Choi wrote: >> If each bus-block has separate regulator independently, each bus-block can >> be registered >> separately. But, exynos bus-blocks in mem-bus-group share the same regulator. > > This can be managed e

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Viresh Kumar
On 20 January 2015 at 17:07, Chanwoo Choi wrote: > If each bus-block has separate regulator independently, each bus-block can be > registered > separately. But, exynos bus-blocks in mem-bus-group share the same regulator. This can be managed easily within the driver. Just stay the highest voltag

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Chanwoo Choi
On 01/20/2015 08:22 PM, Viresh Kumar wrote: > On 20 January 2015 at 13:53, Chanwoo Choi wrote: >> But, the frequency of OPPs is only used for devfreq ondemand governor. >> After deciding the proper frequency of memory bus on ondemand governor, >> exynos-bus.c (exynos memory bus frequency driver) u

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Viresh Kumar
On 20 January 2015 at 13:53, Chanwoo Choi wrote: > But, the frequency of OPPs is only used for devfreq ondemand governor. > After deciding the proper frequency of memory bus on ondemand governor, > exynos-bus.c (exynos memory bus frequency driver) use the frequency table > of memory bus blocks on

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-20 Thread Chanwoo Choi
Hi Viresh, I explained the relation between memory bus group and memory bus block on following patch[1]. - [1] https://lkml.org/lkml/2015/1/8/642 On 01/20/2015 04:19 PM, Viresh Kumar wrote: > On 9 January 2015 at 02:48, Rob Herring wrote: >> Adding Viresh. > > Sorry for being too late, I was v

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-19 Thread Viresh Kumar
On 9 January 2015 at 02:48, Rob Herring wrote: > Adding Viresh. Sorry for being too late, I was very busy with other cpufreq stuff I was doing and saved this thread for later as it required me to understand it properly.. >> +Required properties for memory bus block: >> +- clock-names : the name

Re: Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-13 Thread MyungJoo Ham
Acked-by: MyungJoo Ham Adding to Chanwoo's reply: If I understand Chanwoo's intention correctly, this patchset is to provide a common bus & memory-interface DVFS driver for several Exynos SoCs, which allows DT to express per-SoC hardware details so that we do not need to hardcode them with sep

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-08 Thread Chanwoo Choi
Hi Rob, First of all, thanks for your review. On 01/09/2015 06:18 AM, Rob Herring wrote: > Adding Viresh. > > On Wed, Jan 7, 2015 at 7:40 PM, Chanwoo Choi wrote: >> This patch adds the documentation for generic exynos memory bus frequency >> driver. >> >> Cc: MyungJoo Ham >> Cc: Kyungmin Park

Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-08 Thread Rob Herring
Adding Viresh. On Wed, Jan 7, 2015 at 7:40 PM, Chanwoo Choi wrote: > This patch adds the documentation for generic exynos memory bus frequency > driver. > > Cc: MyungJoo Ham > Cc: Kyungmin Park > Cc: Kukjin Kim > Signed-off-by: Chanwoo Choi > --- > .../devicetree/bindings/devfreq/exynos-busf

[PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-07 Thread Chanwoo Choi
This patch adds the documentation for generic exynos memory bus frequency driver. Cc: MyungJoo Ham Cc: Kyungmin Park Cc: Kukjin Kim Signed-off-by: Chanwoo Choi --- .../devicetree/bindings/devfreq/exynos-busfreq.txt | 184 + 1 file changed, 184 insertions(+) create mode 10