Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-30 Thread Subash Patel
Hi KyongHo, On 03/22/2012 07:29 PM, Subash Patel wrote: Hi KyongHo, On 03/21/2012 05:26 AM, KyongHo Cho wrote: On Tue, Mar 20, 2012 at 10:50 PM, Subash Patel wrote: Sorry for digging this very late. But as part of integrating dma_map v7& sysmmu v12 on 3.3-rc5, I am facing below issue: a) By

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-29 Thread Marek Szyprowski
Hello, On Friday, March 30, 2012 4:24 AM Krishna Reddy wrote: > Hi, > I have found a bug in arm_iommu_map_sg(). > > > +int arm_iommu_map_sg(struct device *dev, struct scatterlist *sg, int nents, > > +enum dma_data_direction dir, struct dma_attrs *attrs) { > > + struct scatterli

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-29 Thread Krishna Reddy
Hi, I have found a bug in arm_iommu_map_sg(). > +int arm_iommu_map_sg(struct device *dev, struct scatterlist *sg, int nents, > + enum dma_data_direction dir, struct dma_attrs *attrs) { > + struct scatterlist *s = sg, *dma = sg, *start = sg; > + int i, count = 0; > + u

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-29 Thread Marek Szyprowski
Hello, On Thursday, March 29, 2012 9:19 AM Hiroshi Doyu wrote: > On Wed, 29 Feb 2012 16:04:22 +0100 > Marek Szyprowski wrote: > > > This patch add a complete implementation of DMA-mapping API for > > devices that have IOMMU support. All DMA-mapping calls are supported. > > > > This patch contai

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-29 Thread Hiroshi Doyu
Hi Marek, On Wed, 29 Feb 2012 16:04:22 +0100 Marek Szyprowski wrote: > This patch add a complete implementation of DMA-mapping API for > devices that have IOMMU support. All DMA-mapping calls are supported. > > This patch contains some of the code kindly provided by Krishna Reddy > and Andrzej

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-22 Thread Subash Patel
Hi KyongHo, On 03/21/2012 05:26 AM, KyongHo Cho wrote: On Tue, Mar 20, 2012 at 10:50 PM, Subash Patel wrote: Sorry for digging this very late. But as part of integrating dma_map v7& sysmmu v12 on 3.3-rc5, I am facing below issue: a) By un-selecting IOMMU in menu config, I am able to allocate

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-20 Thread KyongHo Cho
On Tue, Mar 20, 2012 at 10:50 PM, Subash Patel wrote: > Sorry for digging this very late. But as part of integrating dma_map v7 & > sysmmu v12 on 3.3-rc5, I am facing below issue: > > a) By un-selecting IOMMU in menu config, I am able to allocate memory in > vb2-dma-contig > > b) When I enable SYS

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-20 Thread Subash Patel
Sorry for digging this very late. But as part of integrating dma_map v7 & sysmmu v12 on 3.3-rc5, I am facing below issue: a) By un-selecting IOMMU in menu config, I am able to allocate memory in vb2-dma-contig b) When I enable SYSMMU support for the IP's, I am receiving below fault: Unhandle

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-07 Thread Marek Szyprowski
Hello, On Wednesday, March 07, 2012 8:16 AM Hiroshi Doyu wrote: > From: Hiroshi DOYU > Subject: Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper > Date: Wed, 07 Mar 2012 08:37:06 +0200 (EET) > Message-ID: <20120307.083706.2087121294965856946.hd...@nvidia.c

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-07 Thread Marek Szyprowski
Hello, On Wednesday, March 07, 2012 12:22 AM Russell King - ARM Linux wrote: > On Wed, Feb 29, 2012 at 04:04:22PM +0100, Marek Szyprowski wrote: > > +static int arm_iommu_mmap_attrs(struct device *dev, struct vm_area_struct > > *vma, > > + void *cpu_addr, dma_addr_t dma_addr, size_

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-06 Thread Hiroshi Doyu
From: Hiroshi DOYU Subject: Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper Date: Wed, 07 Mar 2012 08:37:06 +0200 (EET) Message-ID: <20120307.083706.2087121294965856946.hd...@nvidia.com> > From: Hiroshi DOYU > Subject: Re: [PATCHv7 9/9] ARM: dma-mapping: add suppo

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-06 Thread Krishna Reddy
> > > It should be as follows. > > > unsigned int count = 1 << get_order(size) - order; > > To be precise, as below? > > unsigned int count = 1 << (get_order(size) - order); Minus has more precedence than left shift. "1 << get_order(size) - order;" is equivalent to 1 << (get_order(size) - order

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-06 Thread Hiroshi Doyu
From: Hiroshi DOYU Subject: Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper Date: Wed, 07 Mar 2012 08:09:52 +0200 (EET) Message-ID: <20120307.080952.2152478004740487196.hd...@nvidia.com> > From: Krishna Reddy > Subject: RE: [PATCHv7 9/9] ARM: dma-mapping: add suppo

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-06 Thread Hiroshi Doyu
From: Krishna Reddy Subject: RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper Date: Tue, 6 Mar 2012 23:48:42 +0100 Message-ID: <401e54ce964cd94bae1eb4a729c7087e3797011...@hqmail04.nvidia.com> > > > +struct dma_iommu_mapping * > > > +arm_iommu_create_mapp

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-06 Thread Krishna Reddy
> On Wed, Feb 29, 2012 at 04:04:22PM +0100, Marek Szyprowski wrote: > > +static int arm_iommu_mmap_attrs(struct device *dev, struct > vm_area_struct *vma, > > + void *cpu_addr, dma_addr_t dma_addr, size_t size, > > + struct dma_attrs *attrs) > > +{ > > + struct arm_vmr

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-06 Thread Russell King - ARM Linux
On Wed, Feb 29, 2012 at 04:04:22PM +0100, Marek Szyprowski wrote: > +static int arm_iommu_mmap_attrs(struct device *dev, struct vm_area_struct > *vma, > + void *cpu_addr, dma_addr_t dma_addr, size_t size, > + struct dma_attrs *attrs) > +{ > + struct arm_vmregion

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-06 Thread Krishna Reddy
> > +struct dma_iommu_mapping * > > +arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t > > size, > > +int order) > > +{ > > + unsigned int count = (size >> PAGE_SHIFT) - order; > > + unsigned int bitmap_size = BITS_TO_LONGS(count) * sizeof(l

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-05 Thread Marek Szyprowski
Hello, On Monday, March 05, 2012 12:47 PM Hiroshi Doyu wrote: > On Wed, 29 Feb 2012 16:04:22 +0100 > Marek Szyprowski wrote: > > > This patch add a complete implementation of DMA-mapping API for > > devices that have IOMMU support. All DMA-mapping calls are supported. > > > > This patch contain

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-05 Thread Hiroshi Doyu
Hi Marek, On Wed, 29 Feb 2012 16:04:22 +0100 Marek Szyprowski wrote: > This patch add a complete implementation of DMA-mapping API for > devices that have IOMMU support. All DMA-mapping calls are supported. > > This patch contains some of the code kindly provided by Krishna Reddy > and Andrzej

RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-02 Thread Marek Szyprowski
Hello, On Friday, March 02, 2012 9:06 AM KyongHo Cho wrote: > On Thu, Mar 1, 2012 at 12:04 AM, Marek Szyprowski > wrote: > > +/** > > + * arm_iommu_map_sg - map a set of SG buffers for streaming mode DMA > > + * @dev: valid struct device pointer > > + * @sg: list of buffers > > + * @nents: numbe

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-02 Thread KyongHo Cho
On Thu, Mar 1, 2012 at 12:04 AM, Marek Szyprowski wrote: > +/** > + * arm_iommu_map_sg - map a set of SG buffers for streaming mode DMA > + * @dev: valid struct device pointer > + * @sg: list of buffers > + * @nents: number of buffers to map > + * @dir: DMA transfer direction > + * > + * Map a set

[PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-02-29 Thread Marek Szyprowski
This patch add a complete implementation of DMA-mapping API for devices that have IOMMU support. All DMA-mapping calls are supported. This patch contains some of the code kindly provided by Krishna Reddy and Andrzej Pietrasiewicz Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park Re