Re: [RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 19:48:56 Russell King - ARM Linux wrote: > On Sun, Jun 16, 2013 at 10:54:08PM +0200, Tomasz Figa wrote: > > Instead of defining new bool field in vendor_data struct for each > > quirk, it is more reasonable to use a single flags field and make > > each quirk use single bit

Re: [RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

2013-06-17 Thread Russell King - ARM Linux
On Sun, Jun 16, 2013 at 10:54:08PM +0200, Tomasz Figa wrote: > Instead of defining new bool field in vendor_data struct for each quirk, > it is more reasonable to use a single flags field and make each quirk > use single bits. Please explain why this is better over the existing system, and why it

[RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

2013-06-16 Thread Tomasz Figa
Instead of defining new bool field in vendor_data struct for each quirk, it is more reasonable to use a single flags field and make each quirk use single bits. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 31 +-- 1 file changed, 17 insertions(+), 14 delet