RE: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-12 Thread Sangbeom Kim
On Thu, Jun 10, 2011 at 4:27 PM, Jassi Brar wrote: > Though if then everything works fine with system and internal DMA, > maybe it is better to assign platform_name string at runtime from some > module parameter, and leaving the default to normal system DMA ? OK, I will leaving the default to syste

Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Jassi Brar
On Fri, Jun 10, 2011 at 3:46 PM, Mark Brown wrote: > On Fri, Jun 10, 2011 at 03:42:27PM +0530, Jassi Brar wrote: >> On Fri, Jun 10, 2011 at 3:19 PM, Mark Brown > >> > If iDMA is always a better choice on CPUs that support it then the >> > cpu_is_() macros might be a good way to make the selection?

Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Mark Brown
On Fri, Jun 10, 2011 at 03:42:27PM +0530, Jassi Brar wrote: > On Fri, Jun 10, 2011 at 3:19 PM, Mark Brown > > If iDMA is always a better choice on CPUs that support it then the > > cpu_is_() macros might be a good way to make the selection? > Actually I remembered just after I posted - iDMA would

Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Jassi Brar
On Fri, Jun 10, 2011 at 3:19 PM, Mark Brown wrote: > On Fri, Jun 10, 2011 at 12:56:45PM +0530, Jassi Brar wrote: >> On Fri, Jun 10, 2011 at 12:46 PM, Sangbeom Kim wrote: > >> > I only focused on S5PV210 and S5PV310. >> > I didn't consider s3c and s5p series. >> > In the next version, I will delet

Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Mark Brown
On Fri, Jun 10, 2011 at 12:56:45PM +0530, Jassi Brar wrote: > On Fri, Jun 10, 2011 at 12:46 PM, Sangbeom Kim wrote: > > I only focused on S5PV210 and S5PV310. > > I didn't consider s3c and s5p series. > > In the next version, I will delete it. > Though if then everything works fine with system a

Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Jassi Brar
On Fri, Jun 10, 2011 at 12:46 PM, Sangbeom Kim wrote: > On Thu, Jun 9, 2011 at 4:04 PM, Jassi Brar wrote: >> NAK. >> It will break the most common user - SMDK6410, as s3c6410 doesn't have any >> I2S internal DMA. >> Please try to test the changes before submitting. I know it's boring, >> but it's

RE: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Sangbeom Kim
On Thu, Jun 9, 2011 at 4:04 PM, Jassi Brar wrote: > NAK. > It will break the most common user - SMDK6410, as s3c6410 doesn't have any > I2S internal DMA. > Please try to test the changes before submitting. I know it's boring, > but it's even more important :) > > Thanks I only focused on S5PV210

RE: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-09 Thread Sangbeom Kim
On Thu, Jun 09, 2011 at 07:47PM +0900, Mark Brown wrote: > > When you resubmit for the API change update it'd be helpful to update > the changelog to explain why the platforms are being changed to use only > internal DMA - what is the advantage this offers over regular DMA? This > will help users