RE: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread R, Durgadoss
Hi Amit, Thanks for keeping this up. And Sorry for late reply. -Original Message- From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel Kachhap Sent: Saturday, March 03, 2012 4:36 PM To: linux...@lists.linux-foundation.org; linux-samsung-soc@vger.kernel.org Cc:

Re: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread Amit Kachhap
Hi Durgadoss, Thanks for the detailed review. On 12 March 2012 16:21, R, Durgadoss durgados...@intel.com wrote: Hi Amit, Thanks for keeping this up. And Sorry for late reply. -Original Message- From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel Kachhap

RE: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread R, Durgadoss
Hi Amit, [snip.] + +     kobject_uevent(th_zone-therm_dev-device.kobj, KOBJ_CHANGE); Wouldn't it make more sense to pass the trip point id also as an 'env' parameter ? This way, the user space can easily figure out which trip point has been crossed. Its a good suggestion. I will