Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Sylwester Nawrocki
Hello, On 12/21/2011 10:16 AM, Heiko Stübner wrote: Use the data field of of_device_id to hold the type for s3c_cpu_type. Signed-off-by: Heiko Stuebner he...@sntech.de Reviewed-by: Thomas Abraham thomas.abra...@linaro.org --- drivers/rtc/rtc-s3c.c | 31 ++-

Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Heiko Stübner
Hi Kgene, Am Mittwoch, 4. Januar 2012, 12:51:41 schrieb Heiko Stübner: Hi Sylwester, Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki: Hello, On 12/21/2011 10:16 AM, Heiko Stübner wrote: Use the data field of of_device_id to hold the type for s3c_cpu_type.

RE: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Kukjin Kim
Heiko Stübner wrote: Hi Kgene, Am Mittwoch, 4. Januar 2012, 12:51:41 schrieb Heiko Stübner: Hi Sylwester, Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki: Hello, On 12/21/2011 10:16 AM, Heiko Stübner wrote: Use the data field of of_device_id to hold the

Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2011-12-12 Thread Heiko Stübner
Hi Thomas, thanks for your review and you are of course right with both your suggestions. I will submit a v2 series shortly, implementing these suggestions. Heiko Am Sonntag, 11. Dezember 2011, 06:47:43 schrieb Thomas Abraham: Hi Heiko, On 9 December 2011 15:20, Heiko Stübner

Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2011-12-10 Thread Thomas Abraham
Hi Heiko, On 9 December 2011 15:20, Heiko Stübner he...@sntech.de wrote: Use the data field of of_device_id to hold the type for s3c_cpu_type. Signed-off-by: Heiko Stuebner he...@sntech.de ---  drivers/rtc/rtc-s3c.c |   27 +--  1 files changed, 21 insertions(+), 6