RE: [PATCH 2/9] ARM: EXYNOS: add clock part for EXYNOS5250 SoC

2012-02-09 Thread Kukjin Kim
Kyungmin Park wrote: > > On 2/1/12, Kukjin Kim wrote: [snip] > > +static int exynos5_clk_gate_block(struct clk *clk, int enable) > exynos5_clk_block_ctrl? OK, looks better, will change. [snip] > > + .name = "mfc", > > + .devname= "s3c-mfc", > what's this

Re: [PATCH 2/9] ARM: EXYNOS: add clock part for EXYNOS5250 SoC

2012-01-31 Thread Kyungmin Park
On 2/1/12, Kukjin Kim wrote: > Signed-off-by: Kukjin Kim > --- > arch/arm/mach-exynos/clock-exynos5.c | 1258 > > arch/arm/mach-exynos/include/mach/regs-clock.h | 62 ++ Doesn't it better split the three header files? regs-clock.h as wrapper. regs-clock-exynos