Vince Bridgers :
> On Sat, Mar 22, 2014 at 1:23 AM, Byungho An wrote:
> > From: Siva Reddy
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
[snip]
> > + /* Stop Advertising 1000BASE Capability if interface is not GMII
*/
> > + if ((phy_iface == PHY_INTERFACE
Vince Bridgers :
> See comments inline
>
> On Sat, Mar 22, 2014 at 1:23 AM, Byungho An wrote:
> > From: Siva Reddy
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
> >
[snip]
> > + /* program desc registers */
> > + writel(dma_tx >> 32,
> > +
Tomasz Figa :
> On 22.03.2014 22:55, Byungho An wrote:
> >
> > Tomasz Figa :
>
> [snip]
>
> >>> + if (priv->irq <= 0) {
> >>> + dev_err(dev, "sxgbe common irq parsing failed\n");
> >>> + sxgbe_drv_remove(ndev);
> >>> + return -EINVAL;
> >>> + }
> >>> +
> >>> + /* Get th
Vince Bridgers :
> On Sat, Mar 22, 2014 at 1:23 AM, Byungho An wrote:
> > From: Siva Reddy
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
> >
[snip]
> > +static int sxgbe_init_rx_buffers(struct net_device *dev,
> > +struct sxgbe_rx_nor
On 22.03.2014 22:55, Byungho An wrote:
Tomasz Figa :
[snip]
+ if (priv->irq <= 0) {
+ dev_err(dev, "sxgbe common irq parsing failed\n");
+ sxgbe_drv_remove(ndev);
+ return -EINVAL;
+ }
+
+ /* Get the TX/RX IRQ numbers */
+ fo
Tomasz Figa :
> Hi,
>
> I have reviewed the non-net-specific parts of this driver, e.g. platform
driver
> and Device Tree code. Please see my comments inline.
>
> On 22.03.2014 07:23, Byungho An wrote:
> > From: Siva Reddy
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe)
Francois Romieu wrote :
> Byungho An :
> [...]
> > +static int sxgbe_init_rx_buffers(struct net_device *dev,
> > +struct sxgbe_rx_norm_desc *p, int i,
> > +unsigned int dma_buf_sz,
> > +struct sxgbe_rx_queue *rx_
On Sat, 2014-03-22 at 14:01 -0500, Vince Bridgers wrote:
> See comments inline
Do please trim your comments instead of quoting the
_whole_ email.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo i
Hi,
I have reviewed the non-net-specific parts of this driver, e.g. platform
driver and Device Tree code. Please see my comments inline.
On 22.03.2014 07:23, Byungho An wrote:
From: Siva Reddy
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
- sxgbe core initialization
- Tx
Byungho An :
[...]
> +static int sxgbe_init_rx_buffers(struct net_device *dev,
> + struct sxgbe_rx_norm_desc *p, int i,
> + unsigned int dma_buf_sz,
> + struct sxgbe_rx_queue *rx_ring)
> +{
> + struct sxgbe_
10 matches
Mail list logo
