Francois Romieu :
> Byungho An :
> [...]
> > How about below ?
>
> The for loops should be unrolled.
>
> (style: no need to join before branching)
>
> I must go to work, so you'll have to fill the dots in the code below:
>
> priv = sxgbe_drv_probe(&(pdev->dev), plat_dat, addr);
>
Byungho An :
[...]
> How about below ?
The for loops should be unrolled.
(style: no need to join before branching)
I must go to work, so you'll have to fill the dots in the code below:
priv = sxgbe_drv_probe(&(pdev->dev), plat_dat, addr);
if (!priv) {
pr_err("%s
Francois Romieu :
> > +static int sxgbe_platform_probe(struct platform_device *pdev)
> [...]
> > + /* Get the SXGBE common INT information */
> > + priv->irq = irq_of_parse_and_map(node, 0);
> > + if (priv->irq <= 0) {
> > + dev_err(dev, "sxgbe common irq parsing failed\n");
> > +
> +static int sxgbe_platform_probe(struct platform_device *pdev)
[...]
> + /* Get the SXGBE common INT information */
> + priv->irq = irq_of_parse_and_map(node, 0);
> + if (priv->irq <= 0) {
> + dev_err(dev, "sxgbe common irq parsing failed\n");
> + irq_dispose_
