Re: [PATCH v2 1/2] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-08 Thread Russell King - ARM Linux
On Wed, Feb 08, 2012 at 10:10:30AM +0900, Boojin Kim wrote: Russell King - ARM Linux wrote: Now that the PL330 code is entirely out of arch/arm, the header should no longer be in asm/hardware/pl330.h. Definitions private to the driver should be in drivers/dma/pl330.c or a header file

RE: [PATCH v2 1/2] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-07 Thread Boojin Kim
Russell King - ARM Linux wrote: Now that the PL330 code is entirely out of arch/arm, the header should no longer be in asm/hardware/pl330.h. Definitions private to the driver should be in drivers/dma/pl330.c or a header file co-located. Other definitions for interfaces to that driver (eg,

Re: [PATCH v2 1/2] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-01-05 Thread Russell King - ARM Linux
On Mon, Dec 12, 2011 at 10:51:08AM +0900, Boojin Kim wrote: Currently there were two part of DMAC PL330 driver for support old styled s3c-pl330 which has been merged into drivers/dma/pl330.c driver. Actually, there is no reason to separate them now. Basically this patch merges

RE: [PATCH v2 1/2] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-01-05 Thread Kukjin Kim
Russell King - ARM Linux wrote: On Mon, Dec 12, 2011 at 10:51:08AM +0900, Boojin Kim wrote: Currently there were two part of DMAC PL330 driver for support old styled s3c-pl330 which has been merged into drivers/dma/pl330.c driver. Actually, there is no reason to separate them now.