Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

2010-07-02 Thread Maurus Cuelenaere
Op 02-07-10 13:25, Ben Dooks schreef: On 28/06/10 12:28, Maurus Cuelenaere wrote: Op 28-06-10 10:08, Pawel Osciak schreef: Supports all bpp modes. The PRTCON register is used to disable in-hardware updates of registers that store start and end addresses of framebuffer memory. This prevents

Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

2010-07-02 Thread Mark Brown
On Fri, Jul 02, 2010 at 12:25:33PM +0100, Ben Dooks wrote: On 28/06/10 12:28, Maurus Cuelenaere wrote: No need for the '? 1 : 0' I tihnk there is, IIRC there is no neccessity for a compiler to produce one for true, just that the result be !0 The compiler will *produce* 1 for true, but it

RE: [PATCH v3 05/12] s3c-fb: Add support for display panning

2010-07-02 Thread Pawel Osciak
Ben Dooks b...@simtec.co.uk wrote: On 28/06/10 09:08, Pawel Osciak wrote: diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat- samsung/include/plat/regs-fb.h index ac10013..f454e32 100644 --- a/arch/arm/plat-samsung/include/plat/regs-fb.h +++