Re: [PATCH v9 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-03-01 Thread KyongHo Cho
On Tue, Feb 28, 2012 at 4:01 PM, Kyungmin Park wrote: > Hi, > > Some comments. > 1. It's not same patch series. since it has additional feature, > exynos5 series support which don't covered at previous time. > 2. It assumes that name conversion is based on exynos5 as default. now > you use gsc at

RE: [PATCH v9 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-03-01 Thread Marek Szyprowski
Hi, On Tuesday, February 28, 2012 7:37 AM KyongHo Cho wrote: > Changes since v8: > - exynos_iommu_map/unmap() just works for the page sizes >that System MMU supports. (Joerg's comment) > - 1 platform device for 1 H/W though a multimedia accelerator >with several System MMUs attached. >

Re: [PATCH v9 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-02-27 Thread Kyungmin Park
Hi, Some comments. 1. It's not same patch series. since it has additional feature, exynos5 series support which don't covered at previous time. 2. It assumes that name conversion is based on exynos5 as default. now you use gsc at exynos4 even though there's no gsc block. It should be fimc. So I s